-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uni-directional volume-coupled CFD->transport testcase #269
Conversation
Just to avoid confusion: Let's not add connectivity to the Nutils codes here. This might be messy (we use GPs here). Once, we have the OpenFOAM participant, we will get connectivity there and then can test a volume NP mapping. Instead, what we need is dynamic mesh adaptivity in the |
@IshaanDesai and I will work on a adaptive version in a separate branch, so this can be merged from our side. |
Co-authored-by: Benjamin Uekermann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this case and everything seems to be in order 👍 I am working on the remeshing variant of the transport participant in the branch remeshing_volume_nutils_case and will open another PR for it, so we can merge this one 👍
@MakisH still wanted to have a loook. Please merge if you agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very nice addition! Very simple, yet very good example of volume coupling, which will be quite important later on.
I looked over the Nutils scripts and they look reasonable, to the extent I understand Nutils. I also left a few minor comments here and there, with the most important to decide now being the name of the directory.
I ran the case and it seems to be working fine. I then used /usr/bin/time
to measure the runtime and memory consumption, since this seems to be quite a heavy case (great workbench for some performance optimizations). In the end, I got (for max-time=0.1
):
# fluid-nutils
259.72user 69.47system 4:20.69elapsed 126%CPU (0avgtext+0avgdata 327216maxresident)k
648inputs+26496outputs (10major+60725minor)pagefaults 0swaps
# transport-nutils
201.40user 56.23system 3:51.01elapsed 111%CPU (0avgtext+0avgdata 127080maxresident)k
0inputs+46584outputs (3major+27997minor)pagefaults 0swaps
meaning that the simulation till 0.1s took a bit more than 4min, and needed 454MB (327+127) of memory.
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Also: don't forget to make this tutorial available via the sidebar of the website. |
As promised, a uni-directional volume-coupled CFD->transport testcase. To have a somehow interesting volume coupling testcase and in the mid-future, we could do dynamic meshes in the transport solver.
Joint work with @gertjanvanzwieten
@gertjanvanzwieten Do you still want to tweak Nutils stuff?
@MakisH What did we still forget?
Who wants to add an OpenFOAM CFD case? 😁