Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heat-exchaner: the mesh could be coarser (currently, downloading additional files is needed) #6

Closed
2 tasks
MakisH opened this issue Apr 12, 2018 · 8 comments

Comments

@MakisH
Copy link
Member

MakisH commented Apr 12, 2018

Although this is a more complicated scenario and it would be complicated to provide specifications, it would be good to have geometry files somewhere.

For historical reasons, we don't have access to the source geometry files anymore. Reconstructing the geometry or adapting the tutorial to a known geometry would be useful, so that if anyone wants to change one of the solvers, they can do it.

Note that the tutorial should not start from producing the meshes, but the user should be able to do this.

Todo:

  • Add some geometry files (reconstruct or adapt the tutorial)
  • Add short instructions on how to produce the meshes.
BenjaminRodenberg added a commit that referenced this issue Nov 21, 2018
BenjaminRodenberg added a commit that referenced this issue Nov 21, 2018
Updated tutorials w.r.t changes introduced in PR #6 in precice/fenics-adapter
@MakisH MakisH added the good first issue Good for newcomers label Jul 21, 2020
@IshaanDesai
Copy link
Member

Is this still relevant?

@MakisH
Copy link
Member Author

MakisH commented Apr 14, 2021

That's mostly a question of what we want the tutorials to be. If we accept that the tutorials are only to see how things are implemented preCICE-wise, then no, this is not relevant anymore. But we still don't have geometry files and we start from a given mesh.

@davidscn do you maybe know if there are any tools in OpenFOAM to update a given mesh?

@IshaanDesai
Copy link
Member

Also see here as a relevant point in this discussion

@MakisH
Copy link
Member Author

MakisH commented Apr 14, 2021

One additional argument here is that we currently share the complete meshes from LRZ Sync&Share, as they are several MB in size. If we added the mesh generation in the process (or if we managed to make the meshes coarser), we could host everything on GitHub and running would be much faster.

I would keep this issue open, as it affects the tutorials structure.

@MakisH
Copy link
Member Author

MakisH commented Apr 14, 2021

Starting point for potentially coarsening an existing mesh: https://www.cfd-online.com/Forums/openfoam/98093-create-coarser-mesh-post-processing.html

We would then need something similar for CalculiX. Or, again, we remake the case from scratch (but that's a bigger package).

@davidscn
Copy link
Member

@davidscn do you maybe know if there are any tools in OpenFOAM to update a given mesh?

I don't understand what exactly to update, but I guess I'm not aware of anything in this direction.

@MakisH MakisH changed the title CHT with OpenFOAM and CalculiX: geometry specification and files heat-exchaner: geometry specification and files Apr 14, 2021
@MakisH
Copy link
Member Author

MakisH commented Apr 14, 2021

I added a note on the tutorial description to ask for help, pointing to this issue.

@MakisH MakisH changed the title heat-exchaner: geometry specification and files heat-exchaner: the mesh could be coarser (currently, downloading additional files is needed) Apr 14, 2021
@MakisH
Copy link
Member Author

MakisH commented Nov 16, 2022

I think we can now fix this since we have the simplified heat exchanger tutorial: #301

@MakisH MakisH closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants