Check code formatting with autopep8, fix formatting for codebase #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use code and examples from https://github.com/peter-evans/autopep8
|
@IshaanDesai For review: Please take special care about b6e013a, since I touched the tests here. Hopefully did not break anything. |
IshaanDesai
reviewed
Jan 18, 2021
| @@ -5,7 +5,8 @@ | |||
| import precice | |||
|
|
|||
| parser = argparse.ArgumentParser() | |||
| parser.add_argument("configurationFileName", help="Name of the xml config file.", type=str) | |||
| parser.add_argument("configurationFileName", | |||
| help="Name of the xml config file.", type=str) | |||
| parser.add_argument("participantName", help="Name of the solver.", type=str) | |||
| parser.add_argument("meshName", help="Name of the mesh.", type=str) | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| args = None |
IshaanDesai
reviewed
Jan 18, 2021
| @@ -33,7 +34,8 @@ | |||
| solver_process_index = 0 | |||
| solver_process_size = 1 | |||
|
|
|||
| interface = precice.Interface(participant_name, configuration_file_name, solver_process_index, solver_process_size) | |||
| interface = precice.Interface(participant_name, configuration_file_name, | |||
| solver_process_index, solver_process_size) | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| read_data_name, write_data_name = None, None |
This line can go even further below but I was not able to add a suggestion where there was no code change in the review.
IshaanDesai
approved these changes
Jan 18, 2021
Technically yes. However, I think this is a corner case, since also setuptools diverges from this convention: So let's keep it as it is. Thanks for the review! I will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.