Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that input is array_like, if required #80

Merged
merged 8 commits into from
Jan 18, 2021
Merged

Check that input is array_like, if required #80

merged 8 commits into from
Jan 18, 2021

Conversation

BenjaminRodenberg
Copy link
Member

Related to #79.

@BenjaminRodenberg BenjaminRodenberg self-assigned this Jan 15, 2021
@BenjaminRodenberg BenjaminRodenberg added the bug Something isn't working label Jan 15, 2021
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Jan 15, 2021
Closed
@BenjaminRodenberg
Copy link
Member Author

@MakisH @IshaanDesai Note: I will implement check_array_like for all functions that actually accept a array_like, if you agree with the general approach. Just don't want to roll this out to the whole bindings just to revert/change it. Let's prototype this first at the example of read_block_scalar_data and write_block_scalar_data

@BenjaminRodenberg
Copy link
Member Author

You can see the actual error here: https://github.com/precice/python-bindings/pull/80/checks?check_run_id=1710161099#step:7:122

MakisH
MakisH approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message is very helpful and much better than before! 👍

I have not tried running the code. The target branch looks correct. Maybe squash your two commits.

@BenjaminRodenberg
Copy link
Member Author

Now all API functions are fixed in the same fashion. Waiting for the review of @IshaanDesai. I will squash everything into one single commit 👍

@BenjaminRodenberg BenjaminRodenberg merged commit e1ee68a into develop Jan 18, 2021
@BenjaminRodenberg BenjaminRodenberg deleted the i_79 branch January 18, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

@MakisH MakisH MakisH approved these changes

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminRodenberg @MakisH @IshaanDesai