Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mesh name and data name instead of IDs #174

Merged
merged 37 commits into from
Mar 22, 2023
Merged

Use mesh name and data name instead of IDs #174

merged 37 commits into from
Mar 22, 2023

Conversation

IshaanDesai
Copy link
Member

API changes are in line with precice/precice#1588

@IshaanDesai IshaanDesai self-assigned this Mar 9, 2023
IshaanDesai added 21 commits March 9, 2023 14:15
@IshaanDesai
Formatting
2ee8e61
@IshaanDesai
Merge branch 'develop' into names-for-ids-v3
d450d9d
@IshaanDesai
Add correct input arguments to requires_gradient_data_for
47e3759
@IshaanDesai
Remove incorrect user keyword
cebebab
@IshaanDesai
Correct typo
d6848b3
@IshaanDesai
Converting Python string to cython bytes and then passing over as str…
9d9c34b 
…ing_view to C++ API
@IshaanDesai
Add overloaded constructors for string_view to handle Python strings …
faf885b 
…and nullptr
@IshaanDesai
Cast cdef bytes to const char* before handing over to C++ API
787355d
@IshaanDesai
Try options: user --root in build-and-test Actions
9dccf23
@IshaanDesai
Move options: user --root line outside of steps in build-and-test Act…
b3c49ef 
…ions
@IshaanDesai
Add su precice command to switch to user precice
673acc1
@IshaanDesai
Add su root to setup test workflow
02c8336
@IshaanDesai
Use su precice in setup test workflow
b9c771f
@IshaanDesai
Remove the removal of lock files
a714e4d
@IshaanDesai
Add sudo to test which runs on ubuntu-latest and remove old API funct…
0784300 
…ions from .pxd file
@IshaanDesai
Include vector library in test/SolverInterface.cpp
cfa15ea
@IshaanDesai
Modify test/SolverInterface.cpp to what it is in precice:precice
dcf3d59
@IshaanDesai
Add includes for vector and string_view in test/SolverInterface.cpp
9b921c6
@IshaanDesai
Further corrections to test/SolverInterface.cpp
3a105e1
@IshaanDesai
Remove su root from setup_install workflow
08ce0d5
@IshaanDesai
Changing iterator i from int to std::size_t
4abdeb8
BenjaminRodenberg
BenjaminRodenberg reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to judge, because there are many changes. But if the tests work, then it should be fine.

Main thing that confuses me: Do the updates in the CI pipeline really belong here?

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
fsimonis
fsimonis approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@fsimonis fsimonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a sane change. Let's get this merged so that we can test these design changes in the adapters.

@IshaanDesai IshaanDesai merged commit 166c6e1 into develop Mar 22, 2023
@IshaanDesai IshaanDesai deleted the names-for-ids-v3 branch March 22, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsimonis fsimonis fsimonis approved these changes

@BenjaminRodenberg BenjaminRodenberg Awaiting requested review from BenjaminRodenberg

Assignees

@IshaanDesai IshaanDesai

Labels
compatibility
Projects
None yet
Milestone
precice: Version 3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@IshaanDesai @BenjaminRodenberg @fsimonis