Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use benjaminrodenberg/precice:develop #171

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Use benjaminrodenberg/precice:develop #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b03b94
Use develop release of dockerfile
BenjaminRodenberg Mar 2, 2023
518b122
Don't create user
BenjaminRodenberg Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ jobs:
tags: ${{ env.docker_username }}/python-bindings:${{ env.branch }},${{ env.docker_username }}/python-bindings:latest
build-args: |
branch=${{ env.branch }}
from=benjaminrodenberg/precice:develop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to provide a docker image with the latest version of preCICE, because we need to include the breaking changes.

13 changes: 7 additions & 6 deletions tools/releasing/packaging/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@ RUN apt-get -qq update && apt-get -qq install \
pkg-config && \
rm -rf /var/lib/apt/lists/*

## Needed, because precice/precice:latest does not create a user? See also https://github.com/precice/precice/pull/1090
## Needed, if base image does not create a user? See also https://github.com/precice/precice/pull/1090
## At the moment: precice/precice:latest does not create a user, but benjaminrodenberg/precice:develop creates a user
## ------>
# Create user precice
ARG uid=1000
ARG gid=1000
RUN groupadd -g ${gid} precice \
&& useradd -u ${uid} -g ${gid} -m -s /bin/bash precice \
&& sudo usermod -a -G sudo precice
# ARG uid=1000
# ARG gid=1000
# RUN groupadd -g ${gid} precice \
# && useradd -u ${uid} -g ${gid} -m -s /bin/bash precice \
# && sudo usermod -a -G sudo precice
Comment on lines -22 to +27
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See baseimage of benjaminrodenberg/precice:develop, described in precice/precice#1115 (comment)


# Setup passwordless sudo
RUN echo "ALL ALL = (ALL) NOPASSWD: ALL" >> /etc/sudoers
Expand Down