Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use container precice/precice:develop in all Actions #159

Merged
merged 26 commits into from
Mar 9, 2023

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Jan 10, 2023

This PR makes the develop branch of the bindings compatible with precice:develop.

Closes #161, closes #155

@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Jan 27, 2023

Because I would like to use the python bindings with my work in precice/precice#1523, I will work a bit on this branch today. Is there any additional (unpushed) work in this direction? I will start working on a private fork, but I can also push to this branch, if this does not interfere too much with your work (@Timo-Schrader and @IshaanDesai).

@Timo-Schrader
Copy link
Contributor

Sounds good, I don't have any other important changes currently.

@BenjaminRodenberg
Copy link
Member

Installation (pip3 install --user .) and tests (python3 setup.py test) work locally on my system if I use 8c52300. I think there are some problems at the moment (that we cannot really fix here):

@IshaanDesai
Copy link
Member Author

There are no unpushed changes from my side too. This is a pending todo in my list, and I am happy if you push this @BenjaminRodenberg :)

@BenjaminRodenberg BenjaminRodenberg changed the title Make bindings compatible with precice:develop Make bindings compatible with precice:develop and use precice-setup-action Feb 17, 2023
@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Feb 17, 2023

As far as I understand, the main problem why we cannot merge this PR is that the tests don't work with the new action precice-setup-action. Therefore, I removed this part of the testing procedure and instead use my own docker image benjaminrodenberg/precice:develop. See #169

We can still keep this PR and merge it as soon as the precice-setup-action is working. This would then upgrade the tests to this new workflow.

@IshaanDesai IshaanDesai changed the title Make bindings compatible with precice:develop and use precice-setup-action Use precice-setup-action to use precice:develop in testing Feb 20, 2023
@IshaanDesai IshaanDesai changed the title Use precice-setup-action to use precice:develop in testing Use container precice/precice:develop in all Actions Mar 9, 2023
@IshaanDesai IshaanDesai marked this pull request as ready for review March 9, 2023 13:19
@IshaanDesai IshaanDesai merged commit 22a9d3a into develop Mar 9, 2023
@IshaanDesai IshaanDesai deleted the compatibility-precice-dev branch March 9, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants