Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API function to access mesh connectivity requirement #126

Merged
merged 5 commits into from
Oct 7, 2021

Conversation

IshaanDesai
Copy link
Member

Adding API function is_mesh_connectivity_required() based on changes to original API here: precice/precice#1080

@IshaanDesai
Copy link
Member Author

@BenjaminRodenberg I am not sure why the setup_install and subsequent workflows are failing even though the function is_mesh_connectivity_required() exists in the right places. Can you please check once?

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature of one of the added functions was wrong. See here: https://github.com/precice/python-bindings/pull/126/checks?check_run_id=3826417276#step:6:70

I added the fixes below.

test/SolverInterface.cpp Outdated Show resolved Hide resolved
cyprecice/SolverInterface.pxd Outdated Show resolved Hide resolved
@IshaanDesai IshaanDesai merged commit 750261d into develop Oct 7, 2021
@IshaanDesai IshaanDesai deleted the connectivity-requirement-api branch October 7, 2021 13:10
@IshaanDesai IshaanDesai mentioned this pull request Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants