Remove duplicated test run from GH actions #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
approved these changes
Jul 27, 2021
|
But this also changes when the test is run, isn't it? Previously we ran this test always on any branch. Now it's only for master. Is this intended? |
|
Yes, it only runs if you open up a PR. This is intended. |
|
Merging without PR is a bad idea anyway, isn't it? |
Yes. But sometimes it still happens or people just open the PR when development is done. And if failing tests pop up at such a late point in time this might be annoying. Here, I don't think it's critical, but generally I think it's good to know about all requirements (=tests) when you are developing and not only when you are submitting the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests are currently duplicated in PRs, since the
pushevent is triggered as well as thepull_requestevent. We should definitely specify the test branches here so that thepull_requestevent is triggered when opening and syncing PRs and thepushevent is triggered when we actually merge and push to master.