Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for direct mesh access #69

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Conversation

davidscn
Copy link
Member

@davidscn davidscn commented Jul 8, 2021

according to precice/precice#1033

@davidscn davidscn requested a review from uekerman July 8, 2021 12:34
@davidscn
Copy link
Member Author

davidscn commented Jul 8, 2021

I have not built the website locally. Do I need to add the site else-where or is the sidebar enough?

@uekerman
Copy link
Member

uekerman commented Jul 8, 2021

Do I need to add the site else-where or is the sidebar enough?

sidebar is enough.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments already.

@IshaanDesai As you will need this feature eventually, do you want to review the documentation? Do you understand the feature or is anything missing?

@uekerman uekerman requested a review from IshaanDesai July 8, 2021 14:51
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one question and some minor corrections the concept is clear and I look forward to using this extensively 😄

@davidscn davidscn merged commit c91d29e into master Aug 12, 2021
@davidscn davidscn deleted the add-direct-access branch August 12, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants