Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange tutorials sidebar and overview in collections #372

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Apr 9, 2024

Second/follow-up attempt to #345. @uekerman how does this feel?

Main changes:

  • Grouped together similar/derived tutorials into the "Channel transport", "Flow over heated plate", "Partitioned flow", and "Partitioned heat conduction" collections in the sidebar (folders) and in the README (second-level items).
  • Renamed "Basic cases" -> "Featured" and "Further cases" -> "All tutorials" (and the list now contains all, which I think is easier to parse)

Note that now clicking on, e.g., "Partitioned heat conduction" will highlight it in both the "Featured" and the "All tutorials" parts of the sidebar. I guess this is something we can live with.

tutorials-sidebar

Screenshot 2024-04-09 at 15-22-37 A handful of exciting tutorials preCICE - The Coupling Library

@MakisH MakisH requested a review from uekerman April 9, 2024 13:28
@MakisH MakisH self-assigned this Apr 9, 2024
@uekerman
Copy link
Member

uekerman commented Apr 9, 2024

The duplication feels a bit odd, but not a big issue. I am not sure about the wording "featured". I still think that sth like "basic" describes better what these cases are.

@MakisH
Copy link
Member Author

MakisH commented Apr 9, 2024

The duplication feels a bit odd, but not a big issue. I am not sure about the wording "featured". I still think that sth like "basic" describes better what these cases are.

Reverted

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the screenshots, not at the diff.

@MakisH MakisH merged commit 61ecbad into precice:master Apr 9, 2024
2 checks passed
@MakisH MakisH deleted the tutorials-sidebar2 branch April 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants