Migrate SU2 adapter documentation to the SU2 repository (website part) #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
commented
Apr 3, 2024
MakisH
commented
Apr 3, 2024
There was a problem hiding this comment.
Self-reviewing, as this is currently urgent and rudimentary.
All changes look relevant, and I have cleaned up the history as much as possible. I will create a merge commit to keep the individual steps transparent.
I have tested the changes locally, and the submodule points to the latest develop. Of course, we will need to update the submodules after the SU2 adapter docs is actually ported to v3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following (and updating) the instructions.
Corresponding PR in the adapter repository: precice/su2-adapter#37
Remember to switch the su2-adapter branch to
master(ordevelop) after that contains thedocs/folder (switch the submodule and edit the_config.ymlfor thegithub_editme_path). (done)