-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearly differentiate between participant_dt
and dt
#245
Conversation
Yes, why not. I am only afraid that this will be "high effort – low gain". |
@uekerman Any preference |
No, not really. We explain that both are valid options here: https://precice.org/fundamentals-terminology.html#solver-and-participant |
@uekerman I hope I did not oversee any necessary changes. One thing I just stumbled over: Note: Our tutorials currently use Pragmatic suggestion: Let's keep |
Just for completeness: Once we rename the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I think we should be more clear here, because otherwise the double meaning of
dt
can lead to bugs that are difficult to find. During the preCICE workshop 2023 I found a bug in the code of a user where the statementdt = beginTimeStep()
was left out, becausedt
was fixed to a constant before the timeloop starteddt = subcycling_dt
. This is totally understandable from my perspective, if you do not use adaptivity. Why should I redefinedt
in every time step, if it stays the same?The goal of the user was to use subcycling. However, this led to the situation that
dt
was getting smaller thansubcycling_dt
when getting close to the end of the first window:min(precice_dt, subcycling_dt)
returnsprecice_dt < subcycling_dt
and we overwritedt
leading todt < subcycling_dt
for the remainder of the simulation time.I think this is a situation that we can avoid easily and at the same time we can show clearly that there are basically three different
dt
s:dt
which is thedt
that we actually use for the time stepprecice_dt
which is the maximum alloweddt
defined by preCICEparticipant_dt
(orsolver_dt
?) which is thedt
desired by the solver (fixed or computed), but might conflict withprecice_dt
This is still a draft, because we still have the following todos: