Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heat-exchanger-simplified to sidebar #221

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Add heat-exchanger-simplified to sidebar #221

merged 3 commits into from
Nov 16, 2022

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Nov 15, 2022

To merge just before we update master and precice/tutorials#301 has been merged.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to add this also to the Further Cases section of the tutorials page?

@MakisH
Copy link
Member Author

MakisH commented Nov 16, 2022

Don't we want to add this also to the Further Cases section of the tutorials page?

Good point, thanks! I completely forgot about that section. I added it.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just noticed one more thing, I looked up an older pull request when I added a tutorial case and I also added it to the subprojects part of _config.yml. Do we need this?

@MakisH MakisH merged commit e342576 into master Nov 16, 2022
@MakisH MakisH deleted the MakisH-patch-3 branch November 16, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants