Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize functions related to extracting vertex information from FEniCS #147

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

IshaanDesai
Copy link
Member

This PR makes the functions related to extracting vertex information from FEniCS more versatile in terms of its capability to handle problems with different physical dimensions. This PR is one amongst many in the direction of adding the capability of handling 3D cases to the adapter.

@IshaanDesai IshaanDesai self-assigned this Jan 18, 2022
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just a minor observation.

fenicsprecice/adapter_core.py Show resolved Hide resolved
@IshaanDesai IshaanDesai merged commit 67a48b6 into develop Jan 19, 2022
@IshaanDesai IshaanDesai deleted the generalize-vertices-functions branch January 19, 2022 15:30
@BenjaminRodenberg BenjaminRodenberg added this to the v1.3.0 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants