Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to use standard library definitions in API functions and examples #30

Merged
merged 20 commits into from
Dec 19, 2023
Merged

Revert to use standard library definitions in API functions and examples #30

merged 20 commits into from
Dec 19, 2023

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Dec 18, 2023 •
edited
Loading

Description

This PR reverts to using std::string and std::vector in the adapter API functions. During the update for compatibility to precice:develop, inadvertently the API input variables were modified to be of the type precice::string_view and precice::span, which is actually not intended, as these types are not to be used directly by the user.

Checklist

  • I made sure that the source files are formatted properly.
  • I added my changes to the changelog (CHANGELOG.md)

@IshaanDesai IshaanDesai linked an issue Dec 18, 2023 that may be closed by this pull request
Distinct preice::string_views when implicitly constructing from std::string or literal #28
Closed
@IshaanDesai IshaanDesai self-assigned this Dec 18, 2023
@IshaanDesai IshaanDesai added the bug Something isn't working label Dec 18, 2023
mathiskelm
mathiskelm reviewed Dec 19, 2023
View reviewed changes
dumux-precice/couplingadapter.cc Outdated Show resolved Hide resolved
examples/dummysolver/main_dummysolver.cc Outdated Show resolved Hide resolved
examples/dummysolver/main_dummysolver.cc Outdated Show resolved Hide resolved
mathiskelm
mathiskelm reviewed Dec 19, 2023
View reviewed changes
dumux-precice/couplingadapter.cc Outdated Show resolved Hide resolved
dumux-precice/couplingadapter.hh Outdated Show resolved Hide resolved
examples/ff-pm/flow-over-cube-3d/main_ff-reversed.cc Outdated Show resolved Hide resolved
examples/ff-pm/flow-over-cube-3d/main_pm-reversed.cc Outdated Show resolved Hide resolved
@IshaanDesai IshaanDesai changed the title Revert to use standard library definitions in API functions Revert to use standard library definitions in API functions and examples Dec 19, 2023
@IshaanDesai IshaanDesai merged commit b2e120f into develop Dec 19, 2023
6 checks passed
@IshaanDesai IshaanDesai deleted the revert-to-std-lib branch December 19, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiskelm mathiskelm mathiskelm approved these changes

Assignees

@IshaanDesai IshaanDesai

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distinct preice::string_views when implicitly constructing from std::string or literal
2 participants
@IshaanDesai @mathiskelm