Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update steps in installation and also some paths #16

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

IshaanDesai
Copy link
Member

Description

This PR modifies the steps for installing the adapter according to the directory structure one would get by following the latest DuMuX installation steps.

Checklist

  • I updated the documentation.

@IshaanDesai IshaanDesai requested a review from ajaust October 13, 2022 11:13
Copy link
Collaborator

@ajaust ajaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It looks good to me overall. I have only very few minor remarks/questions.

I am fine with the change of dunecontrol to ./dune-common/bin/dunecontrol as this is closer to the DuMuX documentation and we ask the user to clone the adapter to the same directory as DuMuX.

Just as a hint as it might be useful: I liked to install DUNE and potentially DuMuX separately from the adapter since I would not change DUNE nor DuMuX on a regular basis. I added $DUNE_PATH/dune-common/bin to the PATH environment variable such that I could use dunecontrol from everywhere. Additionally one can send the environment variable DUNE_CONTROL_PATH such that dunecontrol finds the installed DUNE modules. You can find an example for this in the Dockerfiles that are part of this repository.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@IshaanDesai
Copy link
Member Author

Just as a hint as it might be useful: I liked to install DUNE and potentially DuMuX separately from the adapter since I would not change DUNE nor DuMuX on a regular basis. I added $DUNE_PATH/dune-common/bin to the PATH environment variable such that I could use dunecontrol from everywhere. Additionally one can send the environment variable DUNE_CONTROL_PATH such that dunecontrol finds the installed DUNE modules. You can find an example for this in the Dockerfiles that are part of this repository.

Thanks for the hint, this is useful!

@IshaanDesai IshaanDesai merged commit 696bbc2 into develop Oct 17, 2022
@IshaanDesai IshaanDesai deleted the update-install-steps branch October 17, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants