-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a unit grid generator #154
Conversation
Release preCICE v2 compatible ASTE version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some linter fixes and maybe a few documentation tweaks, otherwise good to go.
tools/mesh-generators/README.md
Outdated
@@ -8,3 +8,20 @@ python generate_unit_cube.py --mesh coarse.vtk --resolution 0.2 | |||
``` | |||
|
|||
This requires the `gmsh` and `meshio` Python packages. | |||
|
|||
# Unit grid mesh generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The edge length of the mesh is always 1 in each dimension, right? Although this might be clear for you, would be good to add it in a sentence here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add it in the name, but "Unit" already means that 😉
# 100x100x2 3D grid | ||
python generate_unit_grid.py --mesh name.vtu -x 100 -y 100 -z 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it now 3D because of the z=2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, 2 layers in the z direction.
Co-authored-by: Frédéric Simonis <[email protected]>
Main changes of this PR
This PR adds a unit grid generator with adjustable x, y, z dimensions.
Defaults to 2D by default (z=1).
Author's checklist
pre-commit
hook and usedpre-commit run --all
to apply all available hooks.docs/README.md
.precice/tutorials/aste-turbine
.