Add a unit grid generator #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release preCICE v2 compatible ASTE version
davidscn
reviewed
Nov 4, 2022
tools/mesh-generators/README.md
Outdated
| @@ -8,3 +8,20 @@ python generate_unit_cube.py --mesh coarse.vtk --resolution 0.2 | |||
| ``` | |||
|
|
|||
| This requires the `gmsh` and `meshio` Python packages. | |||
|
|
|||
| # Unit grid mesh generator | |||
There was a problem hiding this comment.
The edge length of the mesh is always 1 in each dimension, right? Although this might be clear for you, would be good to add it in a sentence here.
There was a problem hiding this comment.
I can add it in the name, but "Unit" already means that 😉
Comment on lines
+23
to
+24
| # 100x100x2 3D grid | ||
| python generate_unit_grid.py --mesh name.vtu -x 100 -y 100 -z 2 |
There was a problem hiding this comment.
Is it now 3D because of the z=2?
There was a problem hiding this comment.
Exactly, 2 layers in the z direction.
Co-authored-by: Frédéric Simonis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This PR adds a unit grid generator with adjustable x, y, z dimensions.
Defaults to 2D by default (z=1).
Author's checklist
pre-commithook and usedpre-commit run --allto apply all available hooks.docs/README.md.precice/tutorials/aste-turbine.