Pass --arch to node-gyp instead of --target-arch
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically it supports both but --arch is the documented option, that has more logic associated with it, while --target-arch is merely forwarded to gyp. In addition, handle multi-arch values which on our end dictate the output folder but are not understood by node-gyp. Ref #52
This was referenced Aug 29, 2021
|
4.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically it supports both but
--archis the documented option, that has more logic associated with it, while--target-archis merely forwarded to gyp.In addition, handle multi-arch values which on our end dictate the output folder but are not understood by node-gyp.
Ref #52
Before merging, I want to test this on leveldown in combination with prebuild/node-gyp-build#40.