-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename Adapter from liftoff to vungle #5396
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't allow abrupt renames like this without a transition period. Liftoff can become an alias of vungle and then at some point in a major release liftoff can be removed
- update the code so the vungle adapter lists liftoff as an alias.
- leave liftoff documentation in place, create vungle docs
@bretg I'm an Engineer from Liftoff, and we are integrating with @PBDMSFT on this adapter for a while. |
@Vungle-GordonTian - I'm not sure how you can be so certain that no one else has enabled liftoff. How about a compromise:
This way if someone complains to me that we broke their configuration by allowing this rename to take place, we can apologize and give them instructions to replace their YAML file. |
@PBDMSFT Will Xandr work as expected if we use this alias way that @bretg mentioned? |
@Vungle-GordonTian We've already made changes on our side to accommodate "vungle". If you add an alias for "liftoff", the adapter name we originally had, it won't hurt anything. Please keep the "vungle" adapter in place though as that change was already released in Prebid Server and updated on our end. |
Get it. Then we can go on with our integrating test. I will keep vungle adapter in place. I will add alias as Bretg mentioned simutaneously. |
🏷 Type of documentation
📋 Checklist