Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bigoad.md doc #5349

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Add bigoad.md doc #5349

merged 7 commits into from
Jul 25, 2024

Conversation

BIGOAds
Copy link
Contributor

@BIGOAds BIGOAds commented May 27, 2024

🏷 Type of documentation

  • new bid adapter

📋 Checklist

Copy link

netlify bot commented May 27, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit a1c4cfa
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66a0be1ac5718900085bfa32
😎 Deploy Preview https://deploy-preview-5349--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the code PR. I don't see anything in either PBJS or PBS.

  1. Every bidder requires a pbjs or a pbs flag.
  2. There's a lot of missing metadata. Please see https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#user-documentation for the whole list. e.g. floors_supported, safeframes_ok, etc.

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jul 25, 2024

Hi, BigoAd Adapter code has merged. Can this pull request be merged? Thanks

@bretg bretg merged commit 9c5a466 into prebid:master Jul 25, 2024
5 checks passed
@BIGOAds BIGOAds deleted the bigoad-doc branch July 26, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants