-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/colombia bid adapter #5312
Feature/colombia bid adapter #5312
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We have done suggested changes. Please review and merge. Code branch already merged: prebid/Prebid.js#11478 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates @adtech-colombia - but you're still missing a lot of the metadata Prebid publishers have asked for. See https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter ... the full list would look something like:
tcfeu_supported: true/false
dsa_supported: true/false
gvl_id: none
usp_supported: true/false
coppa_supported: true/false
gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp
schain_supported: true/false
dchain_supported: true/false
userId: (list of supported vendors)
media_types: banner, video, native
safeframes_ok: true/false
deals_supported: true/false
floors_supported: true/false
fpd_supported: true/false
pbjs: true/false
pbs: true/false
prebid_member: true/false
multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid
ortb_blocking_supported: true/partial/false
privacy_sandbox: no or comma separated list of paapi
, topics
Explicit 'false' is better than omission.
Since your adapter was released yesterday, will go ahead and merge this, but please take an item to revisit this metadata in the next week or so please.
🏷 Type of documentation
📋 Checklist