-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RixEngine bid adapter documentation #5125
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@xiaochang could you post the link to the PR in the description of this docs PR, please |
Added prebid/Prebid.js#11035 to the description of this PR @muuki88 |
dev-docs/bidders/rixengine.md
Outdated
|
||
### Note | ||
|
||
The RixEngine Bidding adapter requires setup before beginning. Please contact the RixEngine team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiaochang can you provide a email address to contact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muuki88 Please use [email protected] and [email protected]. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I phrased it badly. Can you add a contact address to the docs. Most Adapters have a separate address, e.g. [email protected]
dev-docs/bidders/rixengine.md
Outdated
**Media type support:** | ||
|
||
RixEngine Prebid.js adapter supports `banner`, video and native is not supported yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already represented in the meta fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muuki88 So we don't need to specify Media type support here again? We can remove line 25 to 27?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct 😊
@muuki88 We have updated the PR based on your suggestions. Please review again and let us know if more changes are needed. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 😃 thanks a lot. This PR will be merged, once your prebidjs adapter is released
@muuki88 Our adapter is released https://github.com/prebid/Prebid.js/blob/master/modules/rixengineBidAdapter.js, please merge this PR. Thanks. |
Hi @muuki88 still don't see our documentation live in https://docs.prebid.org/download.html or https://docs.prebid.org/dev-docs/bidders.html, can I ask when we can expect the doc release to happen? |
That's odd 🤔 I'll take a look. The page deployment went well, but it seems those pages have not been updated for some reason. The docs are there ( https://docs.prebid.org/dev-docs/bidders/rixengine.html ), even though the table styling is broken. Haven't noticed that in the PR. |
@muuki88 Thanks, we will do separate PR for the table styling fix. |
🏷 Type of documentation
📋 Checklist