Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RixEngine bid adapter documentation #5125

Merged
merged 6 commits into from
Feb 24, 2024
Merged

Conversation

xiaochang
Copy link
Contributor

@xiaochang xiaochang commented Feb 1, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit a5fe1a7
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/65d784ed1613600008989d86
😎 Deploy Preview https://deploy-preview-5125--prebid-docs-preview.netlify.app/dev-docs/bidders/rixengine
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@muuki88
Copy link
Contributor

muuki88 commented Feb 4, 2024

@xiaochang could you post the link to the PR in the description of this docs PR, please ☺️

@BaiShuoyang
Copy link

@xiaochang could you post the link to the PR in the description of this docs PR, please ☺️

Added prebid/Prebid.js#11035 to the description of this PR @muuki88


### Note

The RixEngine Bidding adapter requires setup before beginning. Please contact the RixEngine team.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaochang can you provide a email address to contact?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I phrased it badly. Can you add a contact address to the docs. Most Adapters have a separate address, e.g. [email protected]

Comment on lines 25 to 27
**Media type support:**

RixEngine Prebid.js adapter supports `banner`, video and native is not supported yet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already represented in the meta fields

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muuki88 So we don't need to specify Media type support here again? We can remove line 25 to 27?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct 😊

@BaiShuoyang
Copy link

@muuki88 We have updated the PR based on your suggestions. Please review again and let us know if more changes are needed. Thanks.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 😃 thanks a lot. This PR will be merged, once your prebidjs adapter is released

@BaiShuoyang
Copy link

Great 😃 thanks a lot. This PR will be merged, once your prebidjs adapter is released

@muuki88 Our adapter is released https://github.com/prebid/Prebid.js/blob/master/modules/rixengineBidAdapter.js, please merge this PR. Thanks.

@muuki88 muuki88 merged commit b33852b into prebid:master Feb 24, 2024
5 checks passed
@BaiShuoyang
Copy link

Hi @muuki88 still don't see our documentation live in https://docs.prebid.org/download.html or https://docs.prebid.org/dev-docs/bidders.html, can I ask when we can expect the doc release to happen?

@muuki88
Copy link
Contributor

muuki88 commented Feb 26, 2024

That's odd 🤔 I'll take a look. The page deployment went well, but it seems those pages have not been updated for some reason.

The docs are there ( https://docs.prebid.org/dev-docs/bidders/rixengine.html ), even though the table styling is broken. Haven't noticed that in the PR.

@BaiShuoyang
Copy link

That's odd 🤔 I'll take a look. The page deployment went well, but it seems those pages have not been updated for some reason.

The docs are there ( https://docs.prebid.org/dev-docs/bidders/rixengine.html ), even though the table styling is broken. Haven't noticed that in the PR.

@muuki88 Thanks, we will do separate PR for the table styling fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants