Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epsilon branding for conversant #4578

Merged
merged 1 commit into from
Jun 15, 2023
Merged

epsilon branding for conversant #4578

merged 1 commit into from
Jun 15, 2023

Conversation

AaronColbyPrice
Copy link
Contributor

@AaronColbyPrice AaronColbyPrice commented May 17, 2023 •
edited by muuki88
Loading

Adding in alias for epsilon in conversant adapter. Related change:

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • [x ] new examples

📋 Checklist

  • [x ] Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify
Copy link

netlify bot commented May 17, 2023 •
edited
Loading

✅ Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit aede6c0
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6466cc011ec9ca00084fea8b
😎 Deploy Preview https://deploy-preview-4578--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ChrisHuie ChrisHuie self-requested a review May 17, 2023 22:47
@ChrisHuie ChrisHuie self-assigned this May 17, 2023
@fowler446
Copy link
Contributor

@ChrisHuie you self assigned this. Is there something you want to double check here?

@AaronColbyPrice
Copy link
Contributor Author

Had to back out some changes, after doing some extra testing and reading on aliasing I realized we are not ready for these yet and it broke the downloads page.

@ChrisHuie ChrisHuie added the LGTM label Jun 1, 2023
@ChrisHuie ChrisHuie removed their assignment Jun 1, 2023
@ChrisHuie ChrisHuie removed their request for review June 1, 2023 11:25
@muuki88 muuki88 merged commit 7a4c434 into prebid:master Jun 15, 2023
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
@AaronColbyPrice @ecdrsvc
epsilon branding for conversant (prebid#4578)
ba54fb9 
Co-authored-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fowler446 fowler446 fowler446 approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronColbyPrice @fowler446 @muuki88 @ChrisHuie