Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Inmar bidder adapter #2585

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Add Inmar bidder adapter #2585

merged 4 commits into from
Dec 17, 2020

Conversation

zandree-owneriq
Copy link
Contributor

@zandree-owneriq zandree-owneriq commented Dec 16, 2020 •
edited
Loading

Inmar bidder adapter documentation

@MartianTribe
Copy link
Collaborator

Hi, can you please link this docs PR to your code PR. Thanks!

bretg
bretg requested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the pbjs: true header or it won't appear in the dynamically-generated page

@bretg bretg mentioned this pull request Dec 16, 2020
Merged
2 tasks
@bretg bretg added needs work and removed question labels Dec 16, 2020
@zandree-owneriq
Copy link
Contributor Author

@bretg I'm confused, I don't see "pbjs: true" in any of the other files in dev-docs/bidders. If this is a requirement, why don't any of the other documentation files have it?

@zandree-owneriq zandree-owneriq mentioned this pull request Dec 17, 2020
Merged
3 tasks
bretg
bretg requested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding pbjs: true. Maybe you forked the docs repo > 4 months ago? All of them have that header field now.

Noticed that you added 'inmarId' as a userId -- unless I'm misunderstanding something, this needs to be removed.

dev-docs/bidders/inmar.md Outdated

biddercode: inmar
usp_supported: true
userIds: inmarId, identityLink, liveIntentId, unifiedId, pubProvidedId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "inmarId" -- there's no user ID module for InMar on https://docs.prebid.org/dev-docs/modules/userId.html nor is there a PR open for a new one.

@gloeffelholz
Copy link

We will remove InmarID. I don't want to duplicate cards here, but we simply do not understand how the GetUserSyncs will result in our ability to get our own Cookie ID in bid requests. If we do not name any field in the bid request for a publisher to send us our UserID we don't understand how we'll ever get that sent to us. We can ideally resolve that in this ticket: prebid/Prebid.js#5674

@bretg
Copy link
Contributor

bretg commented Dec 17, 2020

thanks - this went out with 4.11, so merging now.

@bretg bretg merged commit a48db61 into prebid:master Dec 17, 2020
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Jan 21, 2021
@zandree-owneriq @osazos
Add Inmar bidder adapter (prebid#2585)
67fc449 
* Add Inmar bidder adapter

* Update Inmar bidder adapter documentation

* Update Inmar bidder adapter documentation

* Remove inmarId from userIds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zandree-owneriq @MartianTribe @gloeffelholz @bretg