Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adaptor: Glimpse Protocol #2005

Merged
merged 2 commits into from
Jun 12, 2020
Merged

New Adaptor: Glimpse Protocol #2005

merged 2 commits into from
Jun 12, 2020

Conversation

tim-hm
Copy link
Contributor

@tim-hm tim-hm commented May 22, 2020

New Adapter: Glimpse Protocol
1965b72 
* Initial submission
* Author: Tim Holmes-Mitra <[email protected]>
@tim-hm tim-hm mentioned this pull request May 22, 2020
Merged
1 task
bretg
bretg requested changes May 23, 2020
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add an example and a type for your placementId parameter
  • Please remove the 'table of contents' section -- this isn't long enough to need it

* Removed table of contents
2a82b33 
* Added placementId example and type
tim-hm
tim-hm commented May 29, 2020
View reviewed changes
Copy link
Contributor Author

@tim-hm tim-hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've remove the TOC and added examples and type for placmeentId ... not sure how I missed them in the first place 🤦

@bretg
Copy link
Contributor

bretg commented Jun 12, 2020

released with 3.23

@bretg bretg merged commit db5a497 into prebid:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg requested changes

Assignees
No one assigned
Labels
LGTM not merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tim-hm @bretg @jeanstemp