Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TripleLift Prebid S2S Adapter #954
TripleLift Prebid S2S Adapter #954
Changes from all commits
d2b2e19
d210145
3acedbe
04a6137
5babcb1
a55a9c1
3c4ccbc
44f921b
f9d30c4
9f299fe
bc3b636
408c011
e7cb43d
cf6bbe8
61f72b3
d9b8c59
c6e5f55
a57cfde
1707d8a
6d3a72e
e1efc38
0a25607
856f3ab
c46c510
f49c552
7bd8bb0
2a6c2be
dae5782
b1aa20d
796ab7a
d2d8a8a
02f1073
7d9df4d
a835c6c
eabff67
645879d
68abbf9
3de38ec
248a2b8
22acdce
951dcf4
9c75da6
3d8635a
1160d94
0b59aa4
d14a353
67f241c
863a2c5
0955972
7a1d044
f763064
1e7b6ab
10b2a2d
f6183ff
8b2706b
df5fbc8
21d9526
edda36e
d63b2fd
121efee
0212e67
04063ae
3a35776
4d47460
b1219c3
da4664b
8d64ae3
8a0a65b
6e5024f
9256e07
329cbc1
88e4261
7898b4e
f83bdab
45f6749
7feeb75
f21041d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could just have
if tlext.Floor != nil { imp.BidFloor = *tlext.Floor }
as you returnnil
in either caseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good point, that's a bit more parsimonious. but it seems this is already merged. if I have to patch later I'll take this idea and apply it though.