[Tests] Moving test cases comments to dedicated field #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansinahar
reviewed
Apr 22, 2019
exchange/bidder_test.go
Outdated
| assert.Equal(t, false, (seatBid == nil && tc.expectedBidsCount != 0), fmt.Sprint("Case:", strings.Join(tc.bidCurrency, ","))) | ||
| assert.Equal(t, tc.expectedBidsCount, uint(len(seatBid.bids)), fmt.Sprint("Case:", strings.Join(tc.bidCurrency, ","))) | ||
| assert.ElementsMatch(t, tc.expectedBadCurrencyErrors, errs, fmt.Sprint("Case:", strings.Join(tc.bidCurrency, ","))) | ||
| assert.Equal(t, false, (seatBid == nil && tc.expectedBidsCount != 0), fmt.Sprint("Case:", strings.Join(tc.bidCurrency, ",")), tc.description) |
There was a problem hiding this comment.
Like this approach of adding the descriptions to the table test cases. One question though, since the descriptions are now added, do we still need the existing error messages: fmt.Sprint("Case:", strings.Join(tc.bidCurrency, ",")) ?
There was a problem hiding this comment.
Actually, you are right, we don't need it any longer, I can remove it :)
Thanks !
There was a problem hiding this comment.
Just updated the PR, thanks @mansinahar :)
There was a problem hiding this comment.
Awesome. Thanks @benjaminch !
This CL only introduces a change in couple tests having test cases comments moving those comments in a dedicated field in the test case so it will be printed by assert on fail which ease the debug investigations.
benjaminch
force-pushed
the
add-description-in-test-cases
branch
from
30741e6 to
76b5653
Compare
mansinahar
approved these changes
Apr 22, 2019
|
Thanks @mansinahar :) |
|
Of course! Thanks for the PR @benjaminch :) |
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
This CL only introduces a change in couple tests having test cases comments moving those comments in a dedicated field in the test case so it will be printed by assert on fail which ease the debug investigations.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
This CL only introduces a change in couple tests having test cases comments moving those comments in a dedicated field in the test case so it will be printed by assert on fail which ease the debug investigations.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
This CL only introduces a change in couple tests having test cases comments moving those comments in a dedicated field in the test case so it will be printed by assert on fail which ease the debug investigations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL only introduces a change in couple tests having test cases
comments moving those comments in a dedicated field in the test case so
it will be printed by assert on fail which ease the debug
investigations.