Introduce currency converter mechanism #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL introduces a mechanism to fetch currencies rates periodically from a remote source. Those rates are stored in `CurrencyConverter` struct which can be injected in PBS to get rates. This doesn't introduce any changes in PBS workflow just yet. It also address issues described in prebid#722 regarding httptestClient overload in tests generating errors while running `validate.sh` script. Issue: prebid#280
dbemiller
approved these changes
Oct 24, 2018
hhhjort
approved these changes
Oct 24, 2018
|
Thanks :) |
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
This CL introduces a mechanism to fetch currencies rates periodically from a remote source. Those rates are stored in `CurrencyConverter` struct which can be injected in PBS to get rates. This doesn't introduce any changes in PBS workflow just yet. It also address issues described in prebid#722 regarding httptestClient overload in tests generating errors while running `validate.sh` script. Issue: prebid#280
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
This CL introduces a mechanism to fetch currencies rates periodically from a remote source. Those rates are stored in `CurrencyConverter` struct which can be injected in PBS to get rates. This doesn't introduce any changes in PBS workflow just yet. It also address issues described in prebid#722 regarding httptestClient overload in tests generating errors while running `validate.sh` script. Issue: prebid#280
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
This CL introduces a mechanism to fetch currencies rates periodically from a remote source. Those rates are stored in `CurrencyConverter` struct which can be injected in PBS to get rates. This doesn't introduce any changes in PBS workflow just yet. It also address issues described in prebid#722 regarding httptestClient overload in tests generating errors while running `validate.sh` script. Issue: prebid#280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL introduces a mechanism to fetch currencies rates periodically from a remote source.
Those rates are stored in
CurrencyConverterstruct which can be injected in PBS to get rates.This doesn't introduce any changes in PBS workflow just yet.
It also address issues described in #722 regarding httptestClient overload in tests generating
errors while running
validate.shscript.Issue: #280