Remove 1.11 hack #721
Merged
Remove 1.11 hack #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Removed some of the 1.11 hacks and updated Travis to use Go 1.11.1. * Made a note about Go 1.11 tests in the docs.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Removed some of the 1.11 hacks and updated Travis to use Go 1.11.1. * Made a note about Go 1.11 tests in the docs.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Removed some of the 1.11 hacks and updated Travis to use Go 1.11.1. * Made a note about Go 1.11 tests in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I installed Go 1.11.1. A little while ago, a hack was introduced to work around a bug in Go 1.11 which was fixed in 1.11.1.
Unfortunately... that same hack makes the tests fail on 1.11.1. I haven't looked into it... but @zachbadgett said that compiler directives don't work on minor versions.
Since Go 1.11.1 exists now, I think the best we can do is remove this hack, update Travis to use Go 1.11.1, and document that the unit tests won't work in Go 1.11.