ORTB 2.6: Endpoint JSON test framework captures mock bidder requests #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts and specify bidder ortb version
hhhjort
reviewed
Oct 28, 2024
| @@ -98,7 +98,7 @@ const ( | |||
| // The name refers to the "Adapter" architecture pattern, and should not be confused with a Prebid "Adapter" | |||
| // (which is being phased out and replaced by Bidder for OpenRTB auctions) | |||
| func AdaptBidder(bidder adapters.Bidder, client *http.Client, cfg *config.Configuration, me metrics.MetricsEngine, name openrtb_ext.BidderName, debugInfo *config.DebugInfo, endpointCompression string) AdaptedBidder { | |||
| return &bidderAdapter{ | |||
| return &BidderAdapter{ | |||
There was a problem hiding this comment.
I am not sure why you started exporting BidderAdapter ?
There was a problem hiding this comment.
Oh, nevermind, I see. You need it to extract the mock adapter out of the exchange.
hhhjort
approved these changes
Oct 28, 2024
VeronikaSolovei9
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and allows specifying bidder ortb version