Sonobi: add native support to sonobi adapter #3802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
sonobiRefer here for heat map coverage report |
| userSync: | ||
| iframe: | ||
| url: "https://sync.go.sonobi.com/uc.html?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&loc={{.RedirectURL}}" | ||
| userMacro: "[UID]" |
gargcreation1992
previously approved these changes
Aug 6, 2024
Comment on lines
+143
to
+144
| if imp.Banner == nil && imp.Video == nil && imp.Native != nil { | ||
| mediaType = openrtb_ext.BidTypeNative |
There was a problem hiding this comment.
Code path is not covered. Should add json framework tests for Native media type.
There was a problem hiding this comment.
@bansawbanchee Suggesting you to please use Mtype field set by your adapter response. Here is an example -
func getBidType(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
switch bid.MType {
case openrtb2.MarkupBanner:
return openrtb_ext.BidTypeBanner, nil
case openrtb2.MarkupVideo:
return openrtb_ext.BidTypeVideo, nil
case openrtb2.MarkupNative:
return openrtb_ext.BidTypeNative, nil
}
return "", &errortypes.BadInput{
Message: fmt.Sprintf("Could not define media type for impression: %s", bid.ImpID),
}
}
bansawbanchee
force-pushed
the
sonobi-add-native-support
branch
from
04b0331
to
5933f60
Compare
Code coverage summaryNote:
sonobiRefer here for heat map coverage report |
|
Went ahead and closed this on and combined it into our newest pull request: #3889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.