New Adapter: MetaX #3712
Merged
New Adapter: MetaX #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kehan Pan <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
Signed-off-by: Kehan Pan <[email protected]>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
Signed-off-by: Kehan Pan <[email protected]>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
| @@ -0,0 +1,13 @@ | |||
| endpoint: "https://hb.metaxads.com/prebid?sid={{.PublisherID}}&adunit={{.AdUnit}}&source=prebid-server" | |||
There was a problem hiding this comment.
curl -i --location --request POST 'https://hb.metaxads.com/prebid?sid=22&adunit=1&source=prebid-server'
curl: (6) Could not resolve host: hb.metaxads.com
hb.metaxads.com is not reachable
There was a problem hiding this comment.
hb.metaxads.com dns is mapped to our server now. this endpint is right and the prebid API will be ready in two weeks.
because publisher must be contact us first before using our adapter and the endpoint is well tested in local, i think we can move next
There was a problem hiding this comment.
@metax-kehan, let us know when prebid endpoint is ready. Accordingly, can proceed with reviews.
publisher must be contact us first before using our adapter
should mention this requirement explicitly as comments in bidder-info/metax.yaml
additionally create/update bidder docs PR to specify above requirement behaviour
There was a problem hiding this comment.
codes updated
- prebid endpoint is ready now
- comment in bidder-info/metax.yaml now
- docs PR had the comment already
There was a problem hiding this comment.
endpoint is reachable
% curl -i --location --request POST 'https://hb.metaxads.com/prebid?sid=2&adunit=33&source=prebid-server'
HTTP/1.1 401 Unauthorized
Server: nginx
Date: Mon, 05 Aug 2024 11:24:50 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 21
Connection: keep-alive
invalid sid or adunit
| @@ -0,0 +1,13 @@ | |||
| endpoint: "https://hb.metaxads.com/prebid?sid={{.PublisherID}}&adunit={{.AdUnit}}&source=prebid-server" | |||
| maintainer: | |||
| email: "[email protected]" | |||
There was a problem hiding this comment.
Prebid team has sent an email to verify above specified maintainer email address. Requesting to respond back on email thread
There was a problem hiding this comment.
the email was received and replied
There was a problem hiding this comment.
received response from MetaX
| endpoint: "https://hb.metaxads.com/prebid?sid={{.PublisherID}}&adunit={{.AdUnit}}&source=prebid-server" | ||
| maintainer: | ||
| email: "[email protected]" | ||
| gvlVendorID: 1301 |
There was a problem hiding this comment.
verified gvl ID
curl https://vendor-list.consensu.org/v3/vendor-list.json | jq '.vendors."1301"'
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 606k 100 606k 0 0 8622k 0 --:--:-- --:--:-- --:--:-- 8667k
{
"id": 1301,
"name": "METAX SOFTWARE PTE.LTD.",
"purposes": [
1,
3,
4
],
"legIntPurposes": [
2,
7,
8,
9,
10
],
"flexiblePurposes": [
2,
7,
8,
9,
10
],
"specialPurposes": [
1,
2
],
"features": [
1,
2,
3
],
"specialFeatures": [
1
],
"overflow": {
"httpGetLimit": 32
},
"cookieMaxAgeSeconds": 31536000,
"usesCookies": true,
"cookieRefresh": false,
"usesNonCookieAccess": true,
"dataRetention": {
"stdRetention": 365,
"purposes": {},
"specialPurposes": {}
},
"urls": [
{
"langId": "en",
"privacy": "https://metaxsoft.com/privacy-policy/",
"legIntClaim": "https://metaxsoft.com/privacy-policy/"
}
],
"dataDeclaration": [
1,
2,
3,
4,
5,
6,
7,
8,
9,
10,
11
],
"deviceStorageDisclosureUrl": "https://cdn.metaxads.com/tcf/devicestorage.json"
}
|
@metax-kehan should update json test
|
Signed-off-by: Kehan Pan <[email protected]>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
|
@metax-kehan please link bidder docs PR to this PR |
8 tasks
|
@onkarvhanumante all the issues have been resolved, and the document PR is linked and seems ready to merge. could we go next and let this PR reviewed and merged? please let me know if there anything need i do, thanks |
Signed-off-by: Kehan Pan <[email protected]>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
onkarvhanumante
requested changes
Jul 1, 2024
Signed-off-by: Kehan Pan <[email protected]>
Signed-off-by: Kehan Pan <[email protected]>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
|
@onkarvhanumante @przemkaczmarek |
Signed-off-by: Kehan Pan <[email protected]>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
przemkaczmarek
assigned przemkaczmarek and unassigned onkarvhanumante and przemkaczmarek
przemkaczmarek
previously approved these changes
Aug 2, 2024
adapters/metax/metax.go
Outdated
| "github.com/prebid/prebid-server/v2/util/ptrutil" | ||
| ) | ||
|
|
||
| const SupportedCurrency = "USD" |
There was a problem hiding this comment.
Variable SupportedCurrency is not used. Should remove this variable
Signed-off-by: Kehan Pan <[email protected]>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
|
@onkarvhanumante updated, please review the PR again, thanks |
onkarvhanumante
approved these changes
Aug 6, 2024
|
@przemkaczmarek previous approval was marked as stale due to new changes pushed on to PR. Could you re-review PR |
przemkaczmarek
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New adapter for metaxsoft.com