Yieldmo: Add bid floor currency conversion #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
yieldmoRefer here for heat map coverage report |
|
I'm not sure why the validate merge failed. When I run ./validate.sh --nofmt --cov locally I see a handful of warnings but no errors or failures. Please let me know if you have any advice on what to do about that. |
| } | ||
| imp.BidFloorCur = "USD" | ||
| imp.BidFloor = floor | ||
| } |
There was a problem hiding this comment.
Please add json test case for this change.
There was a problem hiding this comment.
This has been done and it actually did help catch a mistake, so thank you for requesting.
bsardo
changed the title
…ete the preprocess step regardless of whether or not the currency conversion fails, fixed an issue where the currency conversion results were not being applied
Code coverage summaryNote:
yieldmoRefer here for heat map coverage report |
gargcreation1992
approved these changes
May 31, 2024
Sonali-More-Xandr
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds bid floor currency conversion for the Yieldmo adapter. I didn't see any documentation around this functionality, so I largely based this change on the implementations I saw across other adapters. If anyone reviewing this is aware of any documentation or known issues/edge cases with this feature, I would love to hear about them. Thanks!