Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adtelligent: ext aid type #3676

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Adtelligent: ext aid type #3676

merged 8 commits into from
Aug 6, 2024

Conversation

dkornet-ad
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8f22f9b

adtelligent

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:200:	Builder			100.0%
total:										(statements)		90.0%

@SyntaxNode SyntaxNode changed the title ext aid type adtelligent: ext aid type May 9, 2024
aradilov
aradilov reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@aradilov aradilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@GeneGenie GeneGenie mentioned this pull request May 15, 2024
Closed
@GeneGenie
Copy link
Contributor

changes adressing prebid/Prebid.js#6361

@onkarvhanumante
Copy link
Contributor

@dkornet-adtelligent

PR tests are failing. Requesting to fix them

--- FAIL: TestValidParams (0.01s)
    params_test.go:22: Schema rejected adtarget params: {"aid":"123"}
    params_test.go:22: Schema rejected adtarget params: {"aid":"123","siteId":0,"bidFloor":0}
FAIL

@dkornet-ad
Copy link
Contributor Author

@onkarvhanumante fixed

@bsardo bsardo changed the title adtelligent: ext aid type Adtelligent: ext aid type May 23, 2024
onkarvhanumante
onkarvhanumante previously approved these changes Jul 1, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b04754f

adtarget

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adtarget/adtarget.go:23:	MakeRequests			93.3%
github.com/prebid/prebid-server/v2/adapters/adtarget/adtarget.go:84:	MakeBids			92.3%
github.com/prebid/prebid-server/v2/adapters/adtarget/adtarget.go:141:	validateImpressionAndSetExt	85.0%
github.com/prebid/prebid-server/v2/adapters/adtarget/adtarget.go:194:	Builder				100.0%
total:									(statements)			91.0%

adtelligent

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:200:	Builder			100.0%
total:										(statements)		90.0%

@dkornet-ad
Copy link
Contributor Author

@onkarvhanumante @Sonali-More-Xandr

@GeneGenie
Copy link
Contributor

Hello, @onkarvhanumante can this be merged ? =)

@onkarvhanumante onkarvhanumante merged commit c3d8379 into prebid:master Aug 6, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Aug 6, 2024
Closed
@onkarvhanumante
Copy link
Contributor

Hello, @onkarvhanumante can this be merged ? =)

Thanks for keeping patience with PR reviews. PR is merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aradilov aradilov aradilov left review comments

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

Assignees

@onkarvhanumante onkarvhanumante

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkornet-ad @GeneGenie @onkarvhanumante @aradilov @Sonali-More-Xandr