New Adapter: Сointraffic #3647

sergeykcointraffic · 2024-04-26T07:35:38Z

Adds Prebid Server support.

🏷 Type of documentation

🏷 Description of change

official adapter submission
Contact email of the adapter's maintainer [email protected]
A link to a PR on the docs repo at Update Cointraffic for Prebid-Server support prebid.github.io#5323

github-actions · 2024-04-26T07:36:08Z

adapters/cointraffic/cointraffic.go

+		var bidExt openrtb_ext.ExtBid
+		err := json.Unmarshal(bid.Ext, &bidExt)
+		if err == nil && bidExt.Prebid != nil {
+			return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))


Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

SyntaxNode · 2024-04-26T15:11:36Z

adapters/cointraffic/cointraffic.go

+	endpoint string
+}
+
+// Builder builds a new instance of the Foo adapter for the given bidder with the given config.


Thanks for using the template from the docs. Please rename "Foo" to "Cointraffic" for your adapter.

SyntaxNode · 2024-04-26T15:12:45Z

openrtb_ext/imp_cointraffic.go

+package openrtb_ext
+
+type ExtImpCointraffic struct {
+	PlacementId string `json:"PlacementId"`


Please consider using all lower case "placementid" or snake case "placementId" for bidder parameters.

github-actions · 2024-05-16T13:57:48Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 110d864

cointraffic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:19:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:26:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:41:	buildRequest	87.5%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:61:	MakeBids	94.1%
total:										(statements)	90.9%

github-actions · 2024-05-16T14:58:22Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, b3204a2

cointraffic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:19:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:26:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:41:	buildRequest	87.5%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:61:	MakeBids	94.1%
total:										(statements)	90.9%

github-actions · 2024-05-17T10:27:36Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, bf3caf1

cointraffic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:19:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:26:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:41:	buildRequest	87.5%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:61:	MakeBids	94.1%
total:										(statements)	90.9%

onkarvhanumante · 2024-06-05T11:06:30Z

adapters/cointraffic/cointraffic.go

+	if len(request.Imp) == 0 {
+		return nil, []error{&errortypes.BadInput{
+			Message: "No impression in the bid request",
+		}}
+	}


should exclude this check from adapter PR. Prebid server core framework checks for impression length before invoking adapter code

onkarvhanumante · 2024-06-05T11:08:23Z

adapters/cointraffic/cointraffic.go

+	if responseData.StatusCode == http.StatusNoContent {
+		return nil, nil
+	}
+
+	if responseData.StatusCode == http.StatusBadRequest {
+		err := &errortypes.BadInput{
+			Message: fmt.Sprintf("Unexpected code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}
+
+	if responseData.StatusCode != http.StatusOK {
+		err := &errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}
+


could make use of response utils

prebid-server/adapters/response.go

Lines 10 to 28 in ec729e6

func CheckResponseStatusCodeForErrors(response *ResponseData) error {

if response.StatusCode == http.StatusBadRequest {

return &errortypes.BadInput{

Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),

}

}

if response.StatusCode != http.StatusOK {

return &errortypes.BadServerResponse{

Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),

}

}

return nil

}

func IsResponseStatusCodeNoContent(response *ResponseData) bool {

return response.StatusCode == http.StatusNoContent

}

onkarvhanumante · 2024-06-05T11:14:23Z

adapters/cointraffic/cointraffic.go

+
+	bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(response.SeatBid[0].Bid))
+	bidResponse.Currency = response.Cur


adapters.NewBidderResponseWithBidsCapacity initialises bidResponse.Currency with USD value

consider scenario where bidResponse.Currency is empty, assigning response.Cur directly may set bidResponse.Currency to empty value

consider implementing following changes:

bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(response.SeatBid[0].Bid)) if response.Cur != "" { bidResponse.Currency = response.Cur }

onkarvhanumante · 2024-06-05T11:16:42Z

static/bidder-info/cointraffic.yaml

@@ -0,0 +1,10 @@
+endpoint: "https://apps.adsgravity.io/pbs/v1/request"


% curl -i --location --request POST 'https://apps.adsgravity.io/pbs/v1/request' HTTP/2 400 date: Wed, 05 Jun 2024 11:16:14 GMT content-type: text/javascript;charset=UTF-8

endpoint is reachable

onkarvhanumante · 2024-06-05T11:19:28Z

static/bidder-info/cointraffic.yaml

+maintainer:
+  email: [email protected]


Prebid team has sent email to verify above maintainers email. Requesting to responding back on email thread

@sergeykcointraffic Please reply to email sent from us.

@gargcreation1992 We replied to this email a few weeks ago.

We have not received it yet. Please send it again. Is the email bouncing? @stsepelin

@gargcreation1992 Replied.

@stsepelin We have not received it. Could you please check the outbox? Also please check if your email policies allows you to send email outside your org.

@gargcreation1992 Everything seems fine. Could you also check the spam folder/filters?

I see your responses in the spam folder.

I will check if there is anything we can do with this.

onkarvhanumante · 2024-06-05T11:20:33Z

adapters/cointraffic/cointraffictest/exemplary/simple-banner.json

+    "imp": [
+      {
+        "id": "testImpressionId",


should update json test where request has multiple imp

github-actions · 2024-06-10T07:24:14Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c21d599

cointraffic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:17:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:24:	MakeRequests	75.0%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:33:	buildRequest	87.5%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:53:	MakeBids	93.3%
total:										(statements)	89.7%

stsepelin · 2024-06-10T07:28:35Z

Hey @onkarvhanumante! Could you review this pull request again?

onkarvhanumante · 2024-06-25T12:23:13Z

adapters/cointraffic/cointraffic.go

+	return []*adapters.RequestData{requestData}, nil
+}
+
+func (a *adapter) buildRequest(request *openrtb2.BidRequest) (*adapters.RequestData, error) {


buildRequest only builds headers and marshals request. This logic can be moved inside MakeRequests function

onkarvhanumante · 2024-06-25T12:25:40Z

Hey @onkarvhanumante! Could you review this pull request again?

good to merge after addressing #3647 (comment)

github-actions · 2024-06-26T06:42:41Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8872565

cointraffic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:17:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:24:	MakeRequests	88.9%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:46:	MakeBids	93.3%
total:										(statements)	92.3%

bsardo

This is looking good; I have just two nitpicks.

bsardo · 2024-06-27T20:09:32Z

openrtb_ext/bidders.go

@@ -80,6 +80,7 @@ var coreBidderNames []BidderName = []BidderName{
 	BidderCadentApertureMX,
 	BidderCcx,
 	BidderCoinzilla,
+	BidderCointraffic,


Super nitpick: please move this above BidderCoinzilla to maintain alphabetical order.

bsardo · 2024-06-27T20:09:44Z

openrtb_ext/bidders.go

@@ -368,6 +369,7 @@ const (
 	BidderCadentApertureMX  BidderName = "cadent_aperture_mx"
 	BidderCcx               BidderName = "ccx"
 	BidderCoinzilla         BidderName = "coinzilla"
+	BidderCointraffic       BidderName = "cointraffic"


Super nitpick: please move this above BidderCoinzilla to maintain alphabetical order.

github-actions · 2024-06-28T07:44:20Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, cbf5b42

cointraffic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:17:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:24:	MakeRequests	88.9%
github.com/prebid/prebid-server/v2/adapters/cointraffic/cointraffic.go:46:	MakeBids	93.3%
total:										(statements)	92.3%

stsepelin · 2024-06-28T07:46:25Z

@bsardo Thanks for the review. Those two nitpicks are fixed now :)

Co-authored-by: Aleksandr Štšepelin <[email protected]>

Adds cointraffic adapter

ef97284

github-actions bot reviewed Apr 26, 2024

View reviewed changes

sergeykcointraffic marked this pull request as draft April 26, 2024 07:36

SyntaxNode changed the title ~~Adds cointraffic adapter~~ New Adapter: cointraffic Apr 26, 2024

SyntaxNode reviewed Apr 26, 2024

View reviewed changes

stsepelin added 3 commits May 16, 2024 16:40

Merge branch 'prebid:master' into cointraffic

bf6223c

refactor

bb30f63

refactor

110d864

stsepelin mentioned this pull request May 16, 2024

Update Cointraffic for Prebid-Server support prebid/prebid.github.io#5323

Merged

6 tasks

refactor

b3204a2

sergeykcointraffic changed the title ~~New Adapter: cointraffic~~ New Adapter: Сointraffic May 17, 2024

sergeykcointraffic marked this pull request as ready for review May 17, 2024 09:04

refactor

bf3caf1

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Jun 3, 2024

onkarvhanumante reviewed Jun 5, 2024

View reviewed changes

refactor

c21d599

onkarvhanumante reviewed Jun 25, 2024

View reviewed changes

refactor

8872565

onkarvhanumante previously approved these changes Jun 26, 2024

View reviewed changes

bsardo assigned bsardo and unassigned gargcreation1992 Jun 27, 2024

bsardo reviewed Jun 27, 2024

View reviewed changes

refactor

cbf5b42

stsepelin dismissed onkarvhanumante’s stale review via cbf5b42 June 28, 2024 07:43

onkarvhanumante approved these changes Jun 28, 2024

View reviewed changes

onkarvhanumante self-requested a review June 28, 2024 11:30

onkarvhanumante approved these changes Jun 28, 2024

View reviewed changes

bsardo approved these changes Jun 28, 2024

View reviewed changes

bsardo merged commit 057e25d into prebid:master Jun 28, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Jun 28, 2024

Port PR from PBS-Go: New Adapter: Сointraffic prebid/prebid-server-java#3270

Closed

mefjush pushed a commit to adhese/prebid-server that referenced this pull request Jul 19, 2024

New Adapter: Сointraffic (prebid#3647)

d755a99

Co-authored-by: Aleksandr Štšepelin <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: Сointraffic #3647

New Adapter: Сointraffic #3647

sergeykcointraffic commented Apr 26, 2024 •

edited

Loading

github-actions bot Apr 26, 2024

SyntaxNode Apr 26, 2024

SyntaxNode Apr 26, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 17, 2024

onkarvhanumante Jun 5, 2024

onkarvhanumante Jun 5, 2024

onkarvhanumante Jun 5, 2024

onkarvhanumante Jun 5, 2024

onkarvhanumante Jun 5, 2024

gargcreation1992 Jun 21, 2024

stsepelin Jun 21, 2024

gargcreation1992 Jun 25, 2024 •

edited

Loading

stsepelin Jun 25, 2024

gargcreation1992 Jun 26, 2024

stsepelin Jun 26, 2024

bsardo Jun 27, 2024

stsepelin Jun 27, 2024

onkarvhanumante Jun 5, 2024

github-actions bot commented Jun 10, 2024

stsepelin commented Jun 10, 2024

onkarvhanumante Jun 25, 2024

onkarvhanumante commented Jun 25, 2024

github-actions bot commented Jun 26, 2024

bsardo left a comment

bsardo Jun 27, 2024

bsardo Jun 27, 2024

github-actions bot commented Jun 28, 2024

stsepelin commented Jun 28, 2024

	func CheckResponseStatusCodeForErrors(response *ResponseData) error {
	if response.StatusCode == http.StatusBadRequest {
	return &errortypes.BadInput{
	Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),
	}
	}

	if response.StatusCode != http.StatusOK {
	return &errortypes.BadServerResponse{
	Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),
	}
	}

	return nil
	}

	func IsResponseStatusCodeNoContent(response *ResponseData) bool {
	return response.StatusCode == http.StatusNoContent
	}


		bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(response.SeatBid[0].Bid))
		bidResponse.Currency = response.Cur

		@@ -0,0 +1,10 @@
		endpoint: "https://apps.adsgravity.io/pbs/v1/request"

New Adapter: Сointraffic #3647

New Adapter: Сointraffic #3647

Conversation

sergeykcointraffic commented Apr 26, 2024 • edited Loading

🏷 Type of documentation

🏷 Description of change

github-actions bot Apr 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 16, 2024

Code coverage summary

cointraffic

github-actions bot commented May 16, 2024

Code coverage summary

cointraffic

github-actions bot commented May 17, 2024

Code coverage summary

cointraffic

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gargcreation1992 Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 10, 2024

Code coverage summary

cointraffic

stsepelin commented Jun 10, 2024

Choose a reason for hiding this comment

onkarvhanumante commented Jun 25, 2024

github-actions bot commented Jun 26, 2024

Code coverage summary

cointraffic

bsardo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 28, 2024

Code coverage summary

cointraffic

stsepelin commented Jun 28, 2024

sergeykcointraffic commented Apr 26, 2024 •

edited

Loading

gargcreation1992 Jun 25, 2024 •

edited

Loading