Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code coverage workflow to use actions with node 20 support #3470

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

onkarvhanumante
Copy link
Contributor

@onkarvhanumante onkarvhanumante commented Feb 7, 2024

As per, https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20 Node 16 has reached its end of life and it is recommended to transition all actions to run on Node 20 by Spring 2024.

Commit makes changes in code coverage workflow to use actions with node 20 support.
@onkarvhanumante onkarvhanumante changed the title update code coverage workflow to use node 20 actions update code coverage workflow to use node 20 supported actions Feb 7, 2024
@onkarvhanumante onkarvhanumante changed the title update code coverage workflow to use node 20 supported actions update code coverage workflow to use node 20 support Feb 7, 2024
@onkarvhanumante onkarvhanumante changed the title update code coverage workflow to use node 20 support update code coverage workflow to use actions with node 20 support Feb 7, 2024
@AlexBVolcy
Copy link
Contributor

AlexBVolcy commented Feb 7, 2024

Just presenting some additional context regarding GitHub Actions, and the changes made in this PR.

Here are all workflow action uses that were updated in this PR, and their related releases that denote the update from node16 -> node 20

setup-go v5
checkout v4
github-script v7

What setup-go does:

  • Installs Go and Version
  • Sets up environment variables (GOROOT, GOPATH)

What checkout does:

  • Checks out the relevant branch

What github-script does:

  • Allows a workflow to run a custom JavaScript script

How Node.js is related
Node.js isn't directly utilized by setup-go and checkout, but potentially it's used behind the scenes to handle relevant action tasks

Node.js is however directly related to github-script, with the custom JavaScript code provided from the action is run in a Node.js enviornment.

@onkarvhanumante
Copy link
Contributor Author

** Node.js is related** Node.js isn't directly utilized by setup-go and checkout, but potentially it's used behind the scenes to handle relevant action tasks

Node.js is however directly related to

thanks @AlexBVolcy

@bsardo bsardo merged commit cb3fd3c into master Feb 12, 2024
3 checks passed
@onkarvhanumante onkarvhanumante deleted the code-coverage-node-20-support branch February 15, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants