Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yieldmo: Add support for gpp and gpp_sid #3442

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Yieldmo: Add support for gpp and gpp_sid #3442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions adapters/yieldmo/yieldmotest/exemplary/simple-banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@
],
"site": {
"id": "fake-site-id"
},
"regs": {
"coppa": 1,
"ext": {
"gdpr": 1,
"us_privacy": "uspConsentString",
"gpp": "gppString",
"gpp_sid": [6]
}
}
},
"httpCalls": [
Expand All @@ -47,6 +56,15 @@
],
"site": {
"id": "fake-site-id"
},
"regs": {
"coppa": 1,
"ext": {
"gdpr": 1,
"us_privacy": "uspConsentString",
"gpp": "gppString",
"gpp_sid": [6]
}
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion static/bidder-info/yieldmo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ capabilities:
- video
userSync:
redirect:
url: "https://ads.yieldmo.com/pbsync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirectUri={{.RedirectURL}}"
url: "https://ads.yieldmo.com/pbsync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&redirectUri={{.RedirectURL}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user sync url doesn't work for me. It says 400 bad request -
Screenshot 2024-02-05 at 4 31 34 PM

Here is an URL that I am trying -
https://[ads.yieldmo.com](https://ads.yieldmo.com/pbsync?gdpr=&gdpr_consent=&us_privacy=&gpp=&gpp_sid=&redirectUri=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3Dyieldmo%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Di%26uid%3D%24UID)/pbsync?gdpr=&gdpr_consent=&us_privacy=&gpp=&gpp_sid=&redirectUri=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3Dyieldmo%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Di%26uid%3D%24UID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your redirect uri is messed up. Try this: https://ads.yieldmo.com/pbsync?gdpr=&gdpr_consent=&us_privacy=&gpp=&gpp_sid=&redirectUri=https%3A%2F%2Fwww.cnn.com%3Fuid%3D%24UID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gargcreation1992 Can you please merge this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gargcreation1992 @onkarvhanumante Any idea when this will be merged? It's blocking us. Thanks.

userMacro: "$UID"
Loading