Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Adapter: RhythmOne #3129

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Remove Adapter: RhythmOne #3129

merged 1 commit into from
Sep 26, 2023

Conversation

SyntaxNode
Copy link
Contributor

@SyntaxNode SyntaxNode commented Sep 25, 2023 •
edited
Loading

Removing the rhythmone adapter per #2764 for Prebid Server 2.0.

@onkarvhanumante onkarvhanumante mentioned this pull request Sep 25, 2023
Merged
@onkarvhanumante onkarvhanumante self-assigned this Sep 26, 2023
@gargcreation1992 gargcreation1992 self-assigned this Sep 26, 2023
@gargcreation1992
Copy link
Contributor

Merging this PR even there is PR check failing. The failed PR check is for the code coverage comment but this PR removes the adapter and the code coverage is irrelevant here.
There is a fix already shipped to to fix adapter code coverage comment for such PRs.

@gargcreation1992 gargcreation1992 merged commit 6738217 into prebid:master Sep 26, 2023
@SyntaxNode SyntaxNode deleted the remove-rhythmone branch September 26, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

Assignees

@gargcreation1992 gargcreation1992

@onkarvhanumante onkarvhanumante

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyntaxNode @gargcreation1992 @onkarvhanumante