Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huawei Ads: fix cta text empty and fill rate issue #3067

Closed
wants to merge 1 commit into from
Closed

Huawei Ads: fix cta text empty and fill rate issue #3067

wants to merge 1 commit into from

Conversation

ahmetfaruk59
Copy link
Contributor

fix cta text empty and low fill rate issue

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9f3b17e

huaweiads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:266:	MakeRequests				93.3%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:324:	getFinalEndPoint			85.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:354:	MakeBids				91.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:381:	Builder					100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:394:	getExtraInfo				94.1%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:429:	getHeaders				88.9%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:445:	getReqJson				90.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:460:	getReqAdslot30				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:482:	checkAndExtractOpenrtbFormat		100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:510:	getBannerFormat				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:526:	getNativeFormat				92.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:583:	getVideoFormat				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:596:	convertAdtypeStringToInteger		60.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:620:	getReqAppInfo				93.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:654:	getFinalPkgName				93.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:689:	getClientTime				75.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:709:	getReqDeviceInfo			96.6%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:752:	getCountryCode				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:765:	convertCountryCode			75.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:786:	getCountryCodeFromMCC			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:803:	getDeviceIDFromUserExt			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:848:	getReqNetWorkInfo			85.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:884:	getReqRegsInfo				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:893:	getReqGeoInfo				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:905:	getReqConsentInfo			80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:915:	unmarshalExtImpHuaweiAds		88.2%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:942:	checkRespStatusCode			77.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:965:	checkHuaweiAdsResponseRetcode		80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:979:	convertHuaweiAdsRespToBidderResp	90.2%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1048:	getNurl					66.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1061:	handleHuaweiAdsContent			87.5%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1081:	extractAdmBanner			60.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1103:	extractAdmNative			90.6%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1221:	getDecodeValue				80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1232:	jsonEncode				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1241:	extractAdmPicture			90.9%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1304:	getClickUrl				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1321:	getDspImpClickTrackings			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1335:	getStrings				87.5%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1350:	getDuration				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1357:	extractAdmVideo				85.4%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1520:	getVastImpClickErrorTrackingUrls	100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1540:	getVastEventTrackingUrls		100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1560:	computeHmacSha256			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1567:	getDigestAuthorization			100.0%
total:									(statements)				90.5%

@SyntaxNode SyntaxNode changed the title fix cta text empty and fill rate issue Huawei Ads: fix cta text empty and fill rate issue Sep 1, 2023
@SyntaxNode
Copy link
Contributor

IMPORTANT NOTICE:

This adapter is scheduled to be removed from Prebid Server for not having a working contact email address. For us to review this PR, please include an updated group email address in either this PR or via a separate issue.

Please see #2626 for further details.

@ahmetfaruk59 ahmetfaruk59 deleted the adapterHuaweiAds branch September 1, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants