Optimize SetCookieOnResponse() #2819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Jun 6, 2023
There was a problem hiding this comment.
I like the initiative to improve the performance of this algorithm. Please coordinate with @AlexBVolcy who is currently working in this area of code (user sync cookie).
usersync/cookie.go
Outdated
| }) | ||
|
|
||
| // Delete elements until we need no more space to free | ||
| for _, oldestKey := range uuidKeys { |
There was a problem hiding this comment.
IMHO it would be more expressive to use currSize <= cfg.MaxCookieSizeBytes as the for condition and pop the last item from the slice which would be the next oldest item.
There was a problem hiding this comment.
Good point. Modified
|
Discussed offline. Closing as this logic will be incorporated in an upcoming PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented in #1004, function
SetCookieOnResponse()removes the oldest elements from thecookie.uidsmap if it needs extra space to meet thecfg.MaxCookieSizeBytesthreshold. But the implementation can be improved. Let:The current implementatio has square time complexity
O(n^2)because m = n in the worst case scenario. This pull request removes the nested for loop in favor of sorting by expiration date so the new time complexity isO(n*logn).