Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Alias: Epsilon (Conversant) #2781

Merged
merged 3 commits into from
Jun 8, 2023
Merged

New Alias: Epsilon (Conversant) #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed52f70
eps-branding - adding in epsilon alias in prebid server and updating …
May 12, 2023
d39959e
Merge branch 'prebid:master' into eps-branding
AaronColbyPrice May 12, 2023
d5d1483
eps-branding - adding in epsilon alias in prebid server and updating …
May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exchange/adapter_builders.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ func newAdapterBuilders() map[openrtb_ext.BidderName]adapters.Builder {
openrtb_ext.BidderEngageBDR: engagebdr.Builder,
openrtb_ext.BidderEPlanning: eplanning.Builder,
openrtb_ext.BidderEpom: epom.Builder,
openrtb_ext.BidderEpsilon: conversant.Builder,
openrtb_ext.BidderEVolution: evolution.Builder,
openrtb_ext.BidderEvtech: limelightDigital.Builder,
openrtb_ext.BidderFreewheelSSP: freewheelssp.Builder,
Expand Down
2 changes: 2 additions & 0 deletions openrtb_ext/bidders.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ const (
BidderEmxDigital BidderName = "emx_digital"
BidderEngageBDR BidderName = "engagebdr"
BidderEPlanning BidderName = "eplanning"
BidderEpsilon BidderName = "epsilon"
BidderEpom BidderName = "epom"
BidderEVolution BidderName = "e_volution"
BidderEvtech BidderName = "evtech"
Expand Down Expand Up @@ -351,6 +352,7 @@ func CoreBidderNames() []BidderName {
BidderEngageBDR,
BidderEPlanning,
BidderEpom,
BidderEpsilon,
BidderEVolution,
BidderEvtech,
BidderFreewheelSSP,
Expand Down
4 changes: 2 additions & 2 deletions static/bidder-info/conversant.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
endpoint: "http://api.hb.ad.cpe.dotomi.com/cvx/server/hb/ortb/25"
maintainer:
email: "CNVR_PublisherIntegration@conversantmedia.com"
email: "PublisherIntegration@epsilon.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronColbyPrice
Thank you for your contribution to the Prebid server. An email is sent from prebid team to verify [email protected] email address. Please respond back with "received" message to complete verification

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronColbyPrice email has bounced back with following message. Please fix it.

Your message to [email protected] couldn't be delivered.
The group PublisherIntegration only accepts messages from people in its organization or on its allowed senders list, and your email address isn't on the list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkarvhanumante excellent catch, we are testing now and it works internally, but not externally. We are fixing now and I'll follow up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronColbyPrice let us know when to verifiy email again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Email verification is completed!

gvlVendorID: 24
capabilities:
app:
Expand All @@ -15,4 +15,4 @@ userSync:
redirect:
url: "https://prebid-match.dotomi.com/match/bounce/current?version=1&networkId=72582&rurl={{.RedirectURL}}"
userMacro: ""
# conversant appends the user id to end of the redirect url and does not utilize a macro
# epsilon appends the user id to end of the redirect url and does not utilize a macro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this info is related to conversant. Any specific reason to change it to epsilon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversant Media doesn't exist anymore, we've merged with Epsilon so this works is to try and start moving our branding in that direction. However to avoid confusion, it is good to reference our legacy name until we are 100% sure we want to remove it completely.

18 changes: 18 additions & 0 deletions static/bidder-info/epsilon.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
endpoint: "http://api.hb.ad.cpe.dotomi.com/cvx/server/hb/ortb/25"
maintainer:
email: "[email protected]"
gvlVendorID: 24
capabilities:
app:
mediaTypes:
- banner
- video
site:
mediaTypes:
- banner
- video
userSync:
redirect:
url: "https://prebid-match.dotomi.com/match/bounce/current?version=1&networkId=72582&rurl={{.RedirectURL}}"
userMacro: ""
# epsilon/conversant appends the user id to end of the redirect url and does not utilize a macro
6 changes: 3 additions & 3 deletions static/bidder-params/conversant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"$schema": "http://json-schema.org/draft-04/schema#",
"title": "Conversant Adapter Params",
"description": "A schema which validates params accepted by the Conversant adapter.",
"title": "Epsilon (formerly Conversant) Adapter Params",
"description": "A schema which validates params accepted by the Epsilon (Conversant) adapter.",
"type": "object",
"properties": {
"site_id": {
"type": "string",
"description": "A Conversant specific ID which identifies the site."
"description": "An Epsilon (Conversant) specific ID which identifies the site."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this info is related to conversant. Any specific reason to mention epsilon here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversant Media doesn't exist anymore, we've merged with Epsilon so this works is to try and start moving our branding in that direction. However to avoid confusion, it is good to reference our legacy name until we are 100% sure we want to remove it completely.

},
"secure": {
"type": "integer",
Expand Down
54 changes: 54 additions & 0 deletions static/bidder-params/epsilon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"$schema": "http://json-schema.org/draft-04/schema#",
"title": "Epsilon Adapter Params",
"description": "A schema which validates params accepted by the Epsilon adapter.",
"type": "object",
"properties": {
"site_id": {
"type": "string",
"description": "An Epsilon specific ID which identifies the site."
},
"secure": {
"type": "integer",
"description": "Override http/https context on ad markup."
},
"bidfloor" : {
"type": "number",
"description": "Minimum bid price that will be considered."
},
"tag_id": {
"type": "string",
"description": "Identifies specific ad placement."
},
"position": {
"type": "integer",
"description": "Ad position on screen."
},
"mimes": {
"type": "array",
"description": "Array of content MIME types. For videos only.",
"items": {
"type": "string"
}
},
"maxduration": {
"type": "integer",
"description": "Maximum duration in seconds. For videos only."
},
"api": {
"type": "array",
"description": "Array of supported API frameworks. For videos only.",
"items": {
"type": "integer"
}
},
"protocols": {
"type": "array",
"description": "Array of supported video protocols. For videos only.",
"items": {
"type": "integer"
}
}
},
"required": ["site_id"]
}