-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New adapter: Xeworks #2752
New adapter: Xeworks #2752
Conversation
adapters/xeworks/xeworks.go
Outdated
endpoint, err := a.buildEndpointFromRequest(openRTBRequest) | ||
if err != nil { | ||
return nil, []error{err} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are accessing imp[0] in buildEndpointFromRequest method but please be aware that there could be multiple impression in the request. Read more here.
You probably would need a for loop here to handle multiple impressions in the bidRequest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting few changes.
Adding dev-docs PR link :- https://github.com/prebid/prebid.github.io/pull/4543/files |
Hi guys, thank you for the review |
Hello @gargcreation1992 and @Sonali-More-Xandr, could you please review the provided updates? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting few more changes to improve readability and use hostname as query param instead of uri.
@dimashirokov Requesting you to please look at the open comments. |
@gargcreation1992 will check |
@gargcreation1992 could you please check recent update |
@dimashirokov PR checks are failing. Could you please check? |
adapters/xeworks/xeworks.go
Outdated
} | ||
|
||
bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{ | ||
Bid: &bid, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. After the end of for loop, &bid will have the last element of seatBid.Bid slice. I would recommend to change &bid
to &seatBid.Bid[bidId]
.
|
||
for seatId, seatBid := range seats { | ||
for bidId, bid := range seatBid.Bid { | ||
var bidExt bidExt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you are using seatId in the below error messaging but IMHO this is just be iterator values like 0, 1, 2
which won't be helpful in logging, I think. You might wanna remove it.
adapters/xeworks/xeworks.go
Outdated
|
||
if len(errs) > 0 { | ||
return nil, errs | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to simply return - return bidResponse, errs
instead of a check here.
@@ -1,4 +1,4 @@ | |||
endpoint: "http://prebid-{{.Host}}.xe.works/?pid={{.SourceId}}" | |||
endpoint: "http://prebid-srv.xe.works/?pid={{.SourceId}}&host={{.Host}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -1,4 +1,4 @@ | |||
endpoint: "http://prebid-{{.Host}}.xe.works/?pid={{.SourceId}}" | |||
endpoint: "http://prebid-srv.xe.works/?pid={{.SourceId}}&host={{.Host}}" | |||
maintainer: | |||
email: "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sent an email to this address for verification. Please expect an email from [email protected]
and reply with received
. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email was replied. thanks!
Done |
No description provided.