Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename synacormedia adapter to imds to reflect ownership change #2508

Merged
merged 5 commits into from
Jan 19, 2023

Conversation

ecammit
Copy link
Contributor

@ecammit ecammit commented Dec 28, 2022

This rename synacormedia adapter to imds to reflect ownership change, while leaving the synacormedia adapter in place referencing the imds adapter code to allow existing implementations to continue to function under the old name.

See also:
prebid/Prebid.js#9381
prebid/prebid.github.io#4237

guscarreon
guscarreon previously approved these changes Jan 1, 2023
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guscarreon guscarreon self-assigned this Jan 1, 2023
@SyntaxNode SyntaxNode self-requested a review January 6, 2023 20:22
@SyntaxNode SyntaxNode self-assigned this Jan 6, 2023
adapters/imds/imds.go Outdated Show resolved Hide resolved
static/bidder-info/imds.yaml Outdated Show resolved Hide resolved
static/bidder-info/imds.yaml Show resolved Hide resolved
…ails for "imds" and "synacormedia" adapters.
guscarreon
guscarreon previously approved these changes Jan 12, 2023
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bit more research and apparently in YAML quotes are sort of optional and only really needed when we want to escape quotes or other characters. Sorry 😅

LGTM

@ecammit
Copy link
Contributor Author

ecammit commented Jan 12, 2023

Did a bit more research and apparently in YAML quotes are sort of optional and only really needed when we want to escape quotes or other characters. Sorry 😅

LGTM

Not a problem. Happy to quote them anyhow to be safe.

Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SyntaxNode SyntaxNode merged commit 09ee9ad into prebid:master Jan 19, 2023
shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants