Improve Digital adapter: Add deal id and rewardred inventory logic #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbartek25
commented
Oct 27, 2022
jbartek25
commented
- Handle Rewarded inventory flag
- Add dealid
- Handle Rewarded inventory flag - Add dealid
AlexBVolcy
reviewed
Oct 31, 2022
| // BidExt This struct usage for parse line_item_id and buying_type from bid.ext | ||
| type BidExt struct { | ||
| Improvedigital struct { | ||
| LineItemId int `json:"line_item_id"` |
There was a problem hiding this comment.
Nitpick: could you re-name this variable to be LineItemID
| @@ -36,6 +54,15 @@ func (a *ImprovedigitalAdapter) MakeRequests(request *openrtb2.BidRequest, reqIn | |||
| } | |||
|
|
|||
| func (a *ImprovedigitalAdapter) makeRequest(request openrtb2.BidRequest, imp openrtb2.Imp) (*adapters.RequestData, error) { | |||
| // Handle Rewarded Inventory | |||
| extImp, err := getImpExtWithRewardedInventory(imp) | |||
There was a problem hiding this comment.
Nitpick: Could you re-name this to be impExt
mansinahar
reviewed
Nov 2, 2022
| type ImprovedigitalAdapter struct { | ||
| endpoint string | ||
| } | ||
|
|
||
| // BidExt This struct usage for parse line_item_id and buying_type from bid.ext |
There was a problem hiding this comment.
Nitpick: Please rephrase this as BidExt represents Improved Digital bid extension with line item ID and buying type values
mansinahar
previously approved these changes
Nov 3, 2022
…pr-fix Deal id + rewarded inventory flag
|
Sorry for the mess. I thought this PR was already merged. Reopening. |
mansinahar
reviewed
Nov 10, 2022
| return nil, nil | ||
| } | ||
|
|
||
| if string(rewardedInventory) == stateRewardedInventoryEnable { |
There was a problem hiding this comment.
Minor comment: You can simplify this code a little by combining the two if statements as
if rewardedInventory, foundRewardedInventory := prebidMap[isRewardedInventory]; foundRewardedInventory && string(rewardedInventory) == stateRewardedInventoryEnable {
ext[isRewardedInventory] = json.RawMessage(`true`)
impExt, err := json.Marshal(ext)
.
.
}
return nil, nil
mansinahar
approved these changes
Nov 15, 2022
AlexBVolcy
approved these changes
Nov 17, 2022
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Jan 31, 2023
…rebid#2439) Co-authored-by: Samiul Amin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.