New Adapter: VideoHeroes #2399

videoheroes · 2022-09-28T20:59:31Z

No description provided.

bretg · 2022-10-06T21:18:54Z

AlexBVolcy · 2022-10-11T16:31:13Z

adapters/videoheroes/params_test.go

+}
+
+func TestInvalidParams(t *testing.T) {
+	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")


Can we confirm that this file path will always be correct?

Yes, this is correct. Please refer to https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html paragraph "Bidder Parameter Tests"
This is a path to {bidder}.json, it's always in this directory related to adapter code.

AlexBVolcy · 2022-10-11T16:50:17Z

adapters/videoheroes/videoheroes.go

+			return mediaType
+		}
+	}
+	return mediaType


Can you cover this line of code with tests

Technically this case should not happen. It indicates that imp id from response is not found in imp[] from request.
In code many adapters do the same. I think this is ok, but we can discuss it with the team.

AlexBVolcy · 2022-10-11T16:50:50Z

static/bidder-info/videoheroes.yaml

+  app:
+    mediaTypes:
+      - banner
+      - video
+      - native
+  site:
+    mediaTypes:
+      - banner
+      - video
+      - native


I see that you support these media types, but dont see this reflected in your docs PR. Could you update it?

It's already reflected, refer to Line 10, https://github.com/prebid/prebid.github.io/pull/4040/files

VeronikaSolovei9

Thank you for submitting your PR. Added minor comments.

adapters/videoheroes/videoheroes.go

AlexBVolcy · 2022-10-12T19:28:43Z

There is a PR #2370 that is being merged today that will cause conflicts to new adapter PRs.

To resolve these conflicts, you'll need to do the following:

In videoheroes.go, update the Builder() function signature to include a new parameter server config.Server

In videoheroes_test.go, update any test that includes a call to Builder() to pass a config.Server object, to that call (i.e. config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "datacenter"})

After the merge, you can look at other adapters to see how the server object is implemented as an example.

SyntaxNode · 2022-10-12T21:25:48Z

This code is identical to #2396. If these are aliases of the same underlying bidder, it's better to implement it just once and use an alias. Less code to maintain.

videoheroes · 2022-11-04T14:01:26Z

This code is identical to #2396. If these are aliases of the same underlying bidder, it's better to implement it just once and use an alias. Less code to maintain.

It can be the same adapters code (one development), but there different projects and will be different farther

videoheroes · 2022-11-04T15:02:15Z

There is a PR #2370 that is being merged today that will cause conflicts to new adapter PRs.

To resolve these conflicts, you'll need to do the following:

In videoheroes.go, update the Builder() function signature to include a new parameter server config.Server

In videoheroes_test.go, update any test that includes a call to Builder() to pass a config.Server object, to that call (i.e. config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "datacenter"})

After the merge, you can look at other adapters to see how the server object is implemented as an example.

added commit with updates

videoheroes · 2022-11-04T15:03:21Z

Please check it after updates ;)

bsardo · 2022-11-07T16:21:13Z

Hi @videoheroes , can you merge with master when you get a chance? Your code is failing the go 1.19 validation checks due to go fmt changes that were introduced with the recent upgrade to go 1.19 on master.

Also your code is failing the validate-merge step due to some recent changes we made on master regarding the ORTB library. You'll need to update the reference to the mxmcherry version of the library to the prebid version.

videoheroes · 2022-11-15T15:55:56Z

Hi guys, just merged with last version of master and pushed it again, could you please check it ?

bsardo · 2022-11-15T17:41:49Z

@videoheroes you'll need to update the reference to the mxmcherry library in your adapter to github.com/prebid/openrtb/v17/openrtb2. We now use the prebid version of the openrtb2 library.

videoheroes · 2022-11-28T13:34:49Z

heya Guys, could you please review the last updates ?

VeronikaSolovei9 · 2022-11-30T19:50:14Z

adapters/videoheroes/videoheroes.go

+}
+
+func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
+	var videoHeoresExt *openrtb_ext.ExtImpVideoHeroes


Typo in videoHeoresExt -> videoHeroesExt

I'll approve once this typo is fixed!

bsardo · 2022-12-14T17:18:48Z

Hi @videoheroes, can you please undo any changes made to go.mod and go.sum before we merge? Perhaps running go mod tidy will help clear that up.

videoheroes · 2022-12-15T19:09:26Z

Hi @bsardo, I just saw your message and downgraded version of mod, sum files to "162aa91 Update Go version to 1.19 (#2428)"

AlexBVolcy

.

AlexBVolcy

LGTM! Thanks for removing changes to go.mod and go.sum

VeronikaSolovei9

LGTM

New Adapter: VideoHeroes

b1d4b92

bsardo requested a review from AlexBVolcy September 29, 2022 17:25

bsardo assigned AlexBVolcy Sep 29, 2022

SyntaxNode added the port to java label Oct 1, 2022

bsardo requested a review from VeronikaSolovei9 October 6, 2022 18:35

bsardo assigned VeronikaSolovei9 Oct 6, 2022

AlexBVolcy reviewed Oct 11, 2022

View reviewed changes

VeronikaSolovei9 reviewed Oct 12, 2022

View reviewed changes

adapters/videoheroes/videoheroes.go Outdated Show resolved Hide resolved

SyntaxNode mentioned this pull request Oct 12, 2022

New Adapter: Brave #2396

Merged

removed loop, added server config support

6a448fe

root added 2 commits November 15, 2022 15:49

Merge branch 'master' into videoheroes_adapter

9033cfb

merged with master

42bb2f8

changed reference to openrtb2 lib

d5f8510

VeronikaSolovei9 previously approved these changes Nov 30, 2022

View reviewed changes

VeronikaSolovei9 reviewed Nov 30, 2022

View reviewed changes

updated typo difference

14474c7

videoheroes dismissed VeronikaSolovei9’s stale review via 14474c7 December 6, 2022 14:28

VeronikaSolovei9 previously approved these changes Dec 6, 2022

View reviewed changes

AlexBVolcy previously approved these changes Dec 6, 2022

View reviewed changes

checkouted go.* files to previous version

8bd28b8

videoheroes dismissed stale reviews from AlexBVolcy and VeronikaSolovei9 via 8bd28b8 December 15, 2022 19:06

videoheroes requested review from VeronikaSolovei9 and AlexBVolcy and removed request for VeronikaSolovei9 and AlexBVolcy December 28, 2022 13:58

AlexBVolcy reviewed Jan 4, 2023

View reviewed changes

AlexBVolcy approved these changes Jan 4, 2023

View reviewed changes

VeronikaSolovei9 approved these changes Jan 4, 2023

View reviewed changes

bsardo merged commit fa50f2e into prebid:master Jan 4, 2023

aidarbek pushed a commit to aidarbek/prebid-server that referenced this pull request Jan 12, 2023

New Adapter: VideoHeroes (prebid#2399)

d70a9be

shahinrahbariasl pushed a commit to indexexchange/prebid-server that referenced this pull request Jan 18, 2023

New Adapter: VideoHeroes (prebid#2399)

d537c10

shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Jan 31, 2023

New Adapter: VideoHeroes (prebid#2399)

e53c1b5

bretg mentioned this pull request Feb 14, 2023

Port videoheroes adapter prebid/prebid-server-java#2176

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: VideoHeroes #2399

New Adapter: VideoHeroes #2399

videoheroes commented Sep 28, 2022

bretg commented Oct 6, 2022

AlexBVolcy Oct 11, 2022

VeronikaSolovei9 Oct 12, 2022

AlexBVolcy Oct 11, 2022

VeronikaSolovei9 Oct 12, 2022

AlexBVolcy Oct 11, 2022

VeronikaSolovei9 Oct 12, 2022 •

edited

Loading

VeronikaSolovei9 left a comment

AlexBVolcy commented Oct 12, 2022

SyntaxNode commented Oct 12, 2022

videoheroes commented Nov 4, 2022

videoheroes commented Nov 4, 2022

videoheroes commented Nov 4, 2022

bsardo commented Nov 7, 2022

videoheroes commented Nov 15, 2022

bsardo commented Nov 15, 2022

videoheroes commented Nov 28, 2022

VeronikaSolovei9 Nov 30, 2022

AlexBVolcy Dec 5, 2022

videoheroes Dec 6, 2022

bsardo commented Dec 14, 2022

videoheroes commented Dec 15, 2022

AlexBVolcy left a comment •

edited

Loading

AlexBVolcy left a comment

VeronikaSolovei9 left a comment

New Adapter: VideoHeroes #2399

New Adapter: VideoHeroes #2399

Conversation

videoheroes commented Sep 28, 2022

bretg commented Oct 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VeronikaSolovei9 Oct 12, 2022 • edited Loading

Choose a reason for hiding this comment

VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

AlexBVolcy commented Oct 12, 2022

SyntaxNode commented Oct 12, 2022

videoheroes commented Nov 4, 2022

videoheroes commented Nov 4, 2022

videoheroes commented Nov 4, 2022

bsardo commented Nov 7, 2022

videoheroes commented Nov 15, 2022

bsardo commented Nov 15, 2022

videoheroes commented Nov 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsardo commented Dec 14, 2022

videoheroes commented Dec 15, 2022

AlexBVolcy left a comment • edited Loading

Choose a reason for hiding this comment

AlexBVolcy left a comment

Choose a reason for hiding this comment

VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

VeronikaSolovei9 Oct 12, 2022 •

edited

Loading

AlexBVolcy left a comment •

edited

Loading