New Adapter: jixie #1698

jxdeveloper1 · 2021-02-08T01:51:47Z

No description provided.

…he jixie usersync code

…nner*json test file

mansinahar · 2021-02-09T14:44:18Z

adapters/jixie/jixie.go

+
+func buildEndpoint(endpoint string, testing bool, timeout int64) string {
+
+	if timeout == 0 {


You want to set the timeout value outside this function, somewhere in MakeRequests because arguments are pass by value in Go and so only the timeout copy local to this method will be updated to the new value and won't be reflected in req.TMax as you want it to.

tks; tried to fix based on all your comments in 0x1deb9f1 (14 Feb). Sorry I didn't know there is an update slot here.

mansinahar · 2021-02-09T15:11:34Z

adapters/jixie/jixie.go

+		var jxExt openrtb_ext.ExtImpJixie
+		if err := json.Unmarshal(bidderExt.Bidder, &jxExt); err != nil {
+			return nil, []error{&errortypes.BadInput{
+				Message: fmt.Sprintf("ignoring imp id=%s, invalid ImpExt", imp.ID)},


Are you sure you want to return an error here? It might make more sense to append the error and continue processing the rest of the imps. Same for the bidder ext above.

mansinahar · 2021-02-09T15:52:35Z

adapters/jixie/jixie.go

+
+type JixieAdapter struct {
+	endpoint string
+	testing  bool


Looks like you are using the testing field only for JSON tests. This is not really needed as the JSON tests won't be hitting your server and so you can remove this field and also the if block on L43

mansinahar · 2021-02-09T15:58:51Z

adapters/jixie/jixietest/exemplary/banner-and-video-site.json

+    }],
+
+    "expectedBidResponses": [{
+      "bids": [{


Please set the currency field as well here

mansinahar · 2021-02-09T16:00:25Z

adapters/jixie/jixietest/supplemental/add-accountid.json

+    }],
+
+    "expectedBidResponses": [{
+      "bids": [{


Same here. Please add the expected currency as well

guscarreon · 2021-02-12T20:17:03Z

adapters/jixie/jixie.go

+
+func (a *JixieAdapter) MakeRequests(request *openrtb.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
+	var errs []error
+	if len(request.Imp) == 0 {


No need for this check because Prebid Server discards bidRequests with zero-length []Imp arrays upstream and in consequence, makes the true branch of this if statement unreachable.

removed in 0xaa2d1d5. tks

guscarreon · 2021-02-12T20:21:53Z

adapters/jixie/jixie.go

+		}}
+	}
+
+	for _, imp := range request.Imp {


Are we sure we don't want to do anything with the unmarshalled info? Is the purpose of this for loop is just to check if imps don't have unmarshaling errors?

tks for this great note. Now do more checking; + 2 test json files. (in 0xaa2d1d5)

guscarreon · 2021-02-13T07:39:20Z

adapters/jixie/jixie.go

+		addHeaderIfNonEmpty(headers, "Referer", request.Site.Page)
+	}
+
+	theurl := buildEndpoint(a.endpoint, a.testing, request.TMax)


Is testing a left-over from a debug phase?

fixed in earlier commit. tks

guscarreon · 2021-02-13T08:00:03Z

adapters/jixie/params_test.go

+}
+
+var validParams = []string{
+	`{"unit": "1000008-AA77BB88CC", "accountid": "9988776655", "bidfloor": "0.01", "jxprop1": "somethingimportant" }`,


Can we add a test case where unit comes on its own?

done. tks ( 0xaa2d1d5)

guscarreon · 2021-02-13T08:11:25Z

config/config.go

 	setDefaultUsersync(cfg.Adapters, openrtb_ext.BidderKrushmedia, "https://cs.krushmedia.com/4e4abdd5ecc661643458a730b1aa927d.gif?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redir="+url.QueryEscape(externalURL)+"%2Fsetuid%3Fbidder%3Dkrushmedia%26uid%3D%5BUID%5D")
+


Please remove this empty line

Removed. tks (in 0xaa2d1d5)

guscarreon · 2021-02-16T06:23:54Z

adapters/jixie/jixie.go

+		if request.Device.DNT != nil {
+			addHeaderIfNonEmpty(headers, "DNT", strconv.Itoa(int(*request.Device.DNT)))
+		}
+	}


Consider a test that sets the "Accept-Language" and "DNT" the headers:

72 "httpCalls": [{ 73 "expectedRequest": { 74 "uri": "https://hb.jixie.io/v2/hbsvrpost?hbofftest=1", 75 "headers": { 76 "Accept": [ 77 "application/json" 78 ], + "Accept-Language": [ + "anyAcceptLanguageValue" + ], + "DNT": [ + "anyDntValue" + ], 79 "Content-Type": [ 80 "application/json;charset=utf-8" 81 ], 82 "X-Forwarded-For": [ 83 "111.222.333.444" 84 ], 85 "Referer": [ 86 "http://www.publisher.com/today/site?param1=a&param2=b" 87 ], 88 "User-Agent": [ 89 "Mozilla/5.0 (Linux; Android 8.0.0; SM-G960F Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36" 90 ] 91 }, 92 "body": { adapters/jixie/jixietest/exemplary/banner-and-video-site.json

decided not to add the lang and dnt to the headers after all. Changed jixie.go 0xaa2d1d5

guscarreon · 2021-02-16T06:45:12Z

adapters/jixie/jixie.go

+
+//func buildEndpoint(endpoint string, timeout int64) string {
+//	return endpoint + "?pstimeout=" + strconv.FormatInt(timeout, 10)
+//}


Please remove commented lines

removed . tks ( 0xaa2d1d5)

guscarreon · 2021-02-16T06:45:31Z

adapters/jixie/jixie.go

+		addHeaderIfNonEmpty(headers, "Referer", request.Site.Page)
+	}
+
+	//theurl := buildEndpoint(a.endpoint, request.TMax)


Please remove commented lines

done. tks in 0xaa2d1d5

guscarreon · 2021-02-16T06:53:33Z

adapters/jixie/jixie.go

+	if response.StatusCode == http.StatusNoContent {
+		// no bid response
+		return nil, nil
+	}


Other adapters return a BadInput error when a bad request is received. Would it be useful to add that scenario in our context?

124 func (a *JixieAdapter) MakeBids(internalRequest *openrtb.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) { 125 126 if response.StatusCode == http.StatusNoContent { 127 // no bid response 128 return nil, nil 129 } + + if response.StatusCode == http.StatusBadRequest { + return nil, []error{&errortypes.BadInput{ + Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode), + }} + } 130 131 if response.StatusCode != http.StatusOK { 132 return nil, []error{&errortypes.BadServerResponse{ 133 Message: fmt.Sprintf("Invalid Status Returned: %d. Run with request.debug = 1 for more info", response.StatusCode), 134 }} 135 } adapters/jixie/jixie.go

added. tks. in 0xaa2d1d5

-more checking in makerequest of the bidder params (added 2 more test jsons) -removed blank lines, lines commented out -test_params: a case with unit alone -BadInput error

guscarreon

Thank you for addressing our feedback. Your adapter looks pretty good I just have a couple more questions.

guscarreon · 2021-02-21T05:46:21Z

adapters/jixie/jixie.go

+	}
+}
+
+func processImp(imp *openrtb.Imp) error {


Given that Prebid Server core does adapter parameter validation on all Imp[i].ext elements, we can probably spare the processImp(imp *openrtb.Imp) function altoghether because checking for unmarshalling errors and the existence of a non-empty unit field seems to be its sole purpose.

We can accomplish this by adding a minLength restriction to the unit property in file static/bidder-params/jixie.json:

1 { 2 "$schema": "http://json-schema.org/draft-04/schema#", 3 "title": "Jixie Adapter Params", 4 "description": "A schema which validates params accepted by the Jixie adapter", 5 "type": "object", 6 "properties": { 7 "unit" : { 8 "type": "string", 9 "description": "The unit code of an inventory target", + "minLength": 1 10 }, 11 "accountid" : { static/bidder-params/jixie.json

The following test cases verify this point:

41 var invalidParams = []string{ 42 `null`, 43 `nil`, 44 ``, 45 `[]`, 46 `true`, 47 `{}`, 48 `{"unit":12345678}`, 49 `{"Unit":"12345678"}`, 50 `{"unit":"1000008-AA77BB88CC", "bidfloor": 0.01}`, 51 `{"Unit": 12345678}`, 52 `{"AdUnit": "1"}`, 53 `{"adUnit": 1}`, + // empty required argument + `{"unit": ""}`, + // malformed, missing accountid value + `{"unit":"1000008-AA77BB88CC", "accountid", "bidfloor": "0.01", "jxprop1": "somethingimportant" }`, + // malformed + `{"unit":"1000008-AA77BB88CC", malformed, }`, 54 } adapters/jixie/params_test.go

If implemented, we wouldn't need jixietest/supplemental/all-imps-missing-unit.json anymore.

added minLen 18 to be our criteria for unit. didn't know there is this minLength Thanks!!

added minLen 18 to be our criteria for unit. didn't know there is this minLength Thanks!!

@jxdeveloper1 there's even a "pattern" restriction that validates the value of a field matches a regular expression. Do you think it'd be useful in our context?

For instance, if we wanted unit to always look like "1000008-AA77BB88CC", we could probably:

6 "properties": { 7 "unit" : { 8 "type": "string", 9 "description": "The unit code of an inventory target", 10 - "minLength": 18 + "pattern": "^[0-9]{7}-[0-9A-Z]{10}$" 11 }, static/bidder-params/jixie.json

But if you want to use "minLenght" I'm ok either way.

Consider removing processImp, with recent changes it seems to not be called anywhere anymore.

Good catch. If this method exists just for verification, we can remove it and rely on built in functionality of PBS-Core.

guscarreon · 2021-02-21T06:36:40Z

adapters/jixie/jixie.go

+}
+
+func (a *JixieAdapter) MakeRequests(request *openrtb.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
+	var errs = make([]error, 0)


If we discard the processImp(imp *openrtb.Imp) function we could go for a leaner MakeRequests(request *openrtb.BidRequest, reqInfo *adapters.ExtraRequestInfo) version that only marshals and sets headers:

57 func (a *JixieAdapter) MakeRequests(request *openrtb.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) { 58 var errs = make([]error, 0) 59 - 60 - // copy the request, because we are going to mutate it 61 - requestCopy := *request 62 - // this will contain all the valid impressions 63 - var validImps []openrtb.Imp 64 - // pre-process the imps 65 - for _, imp := range requestCopy.Imp { 66 - if err := processImp(&imp); err == nil { 67 - validImps = append(validImps, imp) 68 - } else { 69 - errs = append(errs, err) 70 - } 71 - } 72 - if len(validImps) == 0 { 73 - err := &errortypes.BadInput{ 74 - Message: "No valid impressions for jixie", 75 - } 76 - errs = append(errs, err) 77 - return nil, errs 78 - } 79 - requestCopy.Imp = validImps 80 81 - data, err := json.Marshal(requestCopy) + data, err := json.Marshal(request) 82 if err != nil { 83 errs = append(errs, err) 84 return nil, errs 85 } 86 87 headers := http.Header{} 88 headers.Add("Content-Type", "application/json;charset=utf-8") 89 headers.Add("Accept", "application/json") 90 if request.Device != nil { 91 addHeaderIfNonEmpty(headers, "User-Agent", request.Device.UA) 92 addHeaderIfNonEmpty(headers, "X-Forwarded-For", request.Device.IP) 93 } 94 95 if request.Site != nil { 96 addHeaderIfNonEmpty(headers, "Referer", request.Site.Page) 97 } 98 99 return []*adapters.RequestData{{ 100 Method: "POST", 101 Uri: a.endpoint, 102 Body: data, 103 Headers: headers, 104 }}, errs 105 } adapters/jixie/jixie.go

If implemented, we wouldn't need jixietest/supplemental/all-imps-missing-unit.json anymore.

cleaned up ; tks

guscarreon · 2021-02-21T06:38:28Z

adapters/jixie/jixie.go

+	}}, errs
+}
+
+func ContainsAny(raw string, keys []string) bool {


There's probably no need to export this function. Consider renaming to lowercase

-> containsAny

…r-params/jixie.json file. removed checking in jixie.go that has become unnecssary. removed unnec test cases. updated params-test

guscarreon

Your adapter looks pretty good to me. Left a couple more comments for your consideration.

Also, we usually encourage a test coverage of over a 90% for new adapters.

╰─➤  go test -coverprofile=c.out
PASS
coverage: 70.2% of statements
ok      github.com/prebid/prebid-server/adapters/jixie  0.467s

╰─➤  go tool cover -func=c.out
github.com/prebid/prebid-server/adapters/jixie/jixie.go:21:     Builder                 100.0%
github.com/prebid/prebid-server/adapters/jixie/jixie.go:29:     addHeaderIfNonEmpty     100.0%
github.com/prebid/prebid-server/adapters/jixie/jixie.go:35:     processImp              0.0%
github.com/prebid/prebid-server/adapters/jixie/jixie.go:57:     MakeRequests            85.7%
github.com/prebid/prebid-server/adapters/jixie/jixie.go:86:     containsAny             100.0%
github.com/prebid/prebid-server/adapters/jixie/jixie.go:97:     getBidType              100.0%
github.com/prebid/prebid-server/adapters/jixie/jixie.go:105:    MakeBids                75.0%
github.com/prebid/prebid-server/adapters/jixie/usersync.go:10:  NewJixieSyncer          100.0%
total:                                                          (statements)            70.2%

Thank you for addressing our feedback

guscarreon · 2021-02-22T16:09:17Z

adapters/jixie/jixie.go

+	}
+}
+
+func processImp(imp *openrtb.Imp) error {


Consider removing processImp, with recent changes it seems to not be called anywhere anymore.

static/bidder-params/jixie.json

SyntaxNode · 2021-02-22T18:12:17Z

adapters/jixie/jixie.go

+	"github.com/prebid/prebid-server/openrtb_ext"
+)
+
+type JixieAdapter struct {


Please name this adapter. There is no need to export it with a upper case letter. There is no need to repeat the package name.

done in commit 0x3afae48. thank you

SyntaxNode · 2021-02-22T18:13:10Z

adapters/jixie/jixie.go

+	}
+}
+
+func processImp(imp *openrtb.Imp) error {


Good catch. If this method exists just for verification, we can remove it and rely on built in functionality of PBS-Core.

guscarreon

Looks pretty good to me. Thank you very much for addressing the feedback.

guscarreon

@jxdeveloper1 A couple of things before approving:

I'm sorry I forgot to mention this in my review, but we encourage adapters to include the bid floor in the built-in Imp[i].BidFloor field instead of
defining a bidFloor param altogether? In other words:

  {
    "id": "some_test_auction",
    "imp": [{
      "id": "some_test_ad_id_1",
      "banner": {
        "w": 300,
        "h": 100
      },
 +    "bidfloor": "0.01"
      "ext": {
        "bidder": {
          "unit": "1000008-AbCdEf1234",
 -        "bidfloor": "0.01"
        }
      }
    }],
    "device": {
      "ua": "Mozilla/5.0 (Linux; Android 8.0.0; SM-G960F Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36",
      "ip": "111.222.333.444"
    },
    "site": {
      "domain": "www.publisher.com",
      "page": "http://www.publisher.com/today/site?param1=a&param2=b"
    }
  }

If built-in Imp[i].BidFloor field is used, we no longer need to add the bidfloor param in the static/bidder-params/jixie.json file

 1   {
 2     "$schema": "http://json-schema.org/draft-04/schema#",
 3     "title": "Jixie Adapter Params",
 4     "description": "A schema which validates params accepted by the Jixie adapter",
 5     "type": "object",
 6     "properties": {
 7       "unit" : {
 8         "type": "string",
 9         "description": "The unit code of an inventory target",
10         "minLength": 18
11       },
           .
           .
20       "jxprop2" : {
21         "type": "string",
22         "description": "jxprop2 of an inventory target"
23       },
24 -     "bidfloor": {
25 -       "type": "string",
26 -       "description": "The minimum price acceptable for a bid"
27 -     }
28     },
29     "required": ["unit"]
30   }
static/bidder-params/jixie.json

Nor the BidFloor field in the openrtb_ext/imp_jixie.go file:

1   package openrtb_ext
2  
3   type ExtImpJixie struct {
4       Unit      string `json:"unit"`
5       AccountId string `json:"accountid,omitempty"`
6       JxProp1   string `json:"jxprop1,omitempty"`
7       JxProp2   string `json:"jxprop2,omitempty"`
8 -     BidFloor  string `json:"bidfloor,omitempty"`
9   }
openrtb_ext/imp_jixie.go

Can you please update your documents with the complete list of params?
https://github.com/prebid/prebid.github.io/blob/d72deb6eae00b130e8fdb8329283fcf7e27bfce6/dev-docs/bidders/jixie.md
I'm sorry to bug you again. Other than these two, your adapter looks pretty good.

jxdeveloper1 · 2021-02-24T08:30:58Z

Hi great thanks once again: @guscarreon
1/ For the doc I have made the change and this is the pull request :
prebid/prebid.github.io#2717
2/ Yes indeed bidfloor has been removed from our explicit jixie params

I have a big favour to ask - I have 3 questions. Do you think you can help me with them or tell me what could be a suitable place for me to raise such questions?

QUESTION 1:
The publisher who will be first to use our adaptor uses the Xandr prebid-server service.
Can I then assume - Once a new adaptor is incorporated into the latest prebid-server codebase, Xandr will ‘take’ it without much delay?

i.e. This publisher only need to ensure their stored-requests (or whatever) submitted includes “jixie” (jixie “unit” ..). (i.e. They do not need to “request” Xandr to update so that it has the Jixie adapter?)

QUESTION 2:
If one wants to develop a kind of analytics to log how various bidders bid for each publisher with more fine-grained info (more dimensions...) (The metrics+labels from prebid-server/metrics seems rather coarse-grained and more useful to “make sure everything is generally ok”. The bid "histograms" have only few "labels"), then this is the “framework” one should adhere to -
https://docs.prebid.org/prebid-server/developers/pbs-build-an-analytics-adapter.html#adding-an-analytics-adapter-in-pbs-go
Correct?

QUESTION 3: (Sorry ... this one could be a bit crazy/ignorant; trying my luck)
--Am new to “Golang”, new to prebid-server etc. I started to try to know these things a little bit better.
--I put the prebid-server (docker image) on Azure App service.
(Note: This type of service they will autoscale more instances for you (load-balancing and all that stuff) .... I could have used AWS ECS too)
--It actually works in the sense I can fire requests (openrtb2/auction) at that azure endpoint and get bid responses.

--But e.g. monitoring the Prometheus metrics won't there be a problem?(Works fine if I run prebid-server locally (nondocker)
1/ This type of appservice arrangement can expose only 1 port - And I have it for the main server to do the “real work” – openrtb2/auction etc. But then the Prometheus (‘metrics/’ endpoint) listens on another port. But then the outside cannot reach its /metrics then.
2/ even if I have a solution for 1/, but then each of the (e.g. 5 - as the load balancer sees fit) running instance has its own set of Prom stats (counter, histogram types). But then, how can they be reached individually then (A call to the my-azurehosted-prebidserver.com/metrics would be answered by any one of the running instances); and even if can, how can their results be meaningfully “combined” (each if 1 prebid-server running) ?

Maybe I am thinking too simplistically. I’d imagine people do put prebid-server in the cloud in this kind of setup. Just wondering what they do then.

hhhjort · 2021-02-24T21:05:38Z

Some answers:
QUESTION 1:
Xandr will pick up new adapters in rather short order

QUESTION 2:
That would be the correct place for documentation on how to code an adapter. Given question 1, Xandr already has its own analytics wrapped around PBS, it would be a big ask to get your own analytics running in their environment. (It would expose all traffic passing through Xandr PBS, and thus there would be high trust needed that one customer's data is not shared with a competing customer for example)

QUESTION 3:
Prometheus will work in a kubernetes cluster. Since Prometheus is a pull service, and by default you can't inventory and contact all pods, some glue code/service is needed to connect the pieces. Azure can probably help you with that, I would assume it is a common setup people are using. If not, do a search on Prometheus and Kubernetes and you should find the glue documentation.

guscarreon

LGTM. @jxdeveloper1 thank you for addressing our feedback and for doing it so fast. My teammate @hhhjort provided answers for you but if you have any further questions, please let us know.

I also approved your documents PR. Next, a second reviewer will take a look at both pull requests.

jxdeveloper1 · 2021-02-25T05:43:41Z

thanks @hhhjort for your answers!
thanks @guscarreon for your patience reviews and suggestions.

(I removed my silly question)

hhhjort

LGTM

jxdeveloper1 added 7 commits December 6, 2020 22:18

initial commit

d1b02ca

added notes file for temp use

2791c33

jixie adapter development work

7dfd8de

jixie adaptor development work: mainly the test json files but also t…

a0db22b

…he jixie usersync code

added a test case with accountid. and cosmetic line changes in the ba…

6763e62

…nner*json test file

Merge remote-tracking branch 'upstream/master'

91254f0

updated the jixie user sync: the endpoint and some params stuf

cd02c6f

SyntaxNode changed the title ~~Addition of new adapter: jixie for prebid-server~~ New Adapter: jixie Feb 8, 2021

SyntaxNode requested review from guscarreon and mansinahar February 8, 2021 18:43

SyntaxNode assigned mansinahar and guscarreon Feb 8, 2021

mansinahar reviewed Feb 9, 2021

View reviewed changes

tks and fixing per comments on pull request 1698

1deb9f1

guscarreon requested changes Feb 16, 2021

View reviewed changes

responding to guscarreon's comments:

aa2d1d5

-more checking in makerequest of the bidder params (added 2 more test jsons) -removed blank lines, lines commented out -test_params: a case with unit alone -BadInput error

guscarreon reviewed Feb 21, 2021

View reviewed changes

jxdeveloper1 added 2 commits February 22, 2021 21:59

responding to review. put condition on jixie unit string in the bidde…

b860723

…r-params/jixie.json file. removed checking in jixie.go that has become unnecssary. removed unnec test cases. updated params-test

added one failed params test

74d0d66

guscarreon reviewed Feb 22, 2021

View reviewed changes

SyntaxNode reviewed Feb 22, 2021

View reviewed changes

jxdeveloper1 added 2 commits February 23, 2021 14:21

removed a function that I no longer call!

f6e5078

renamed JixieAdapter to adapter

3afae48

guscarreon approved these changes Feb 23, 2021

View reviewed changes

guscarreon requested changes Feb 23, 2021

View reviewed changes

removed bidfloor from jixie explicit ext params

feaca0c

SyntaxNode assigned hhhjort and unassigned mansinahar Feb 24, 2021

guscarreon approved these changes Feb 25, 2021

View reviewed changes

hhhjort approved these changes Feb 25, 2021

View reviewed changes

hhhjort merged commit fc4bb44 into prebid:master Feb 25, 2021

rpanchyk mentioned this pull request Apr 27, 2021

Implement Jixie bidder prebid/prebid-server-java#1189

Merged


		func buildEndpoint(endpoint string, testing bool, timeout int64) string {

		if timeout == 0 {

		setDefaultUsersync(cfg.Adapters, openrtb_ext.BidderKrushmedia, "https://cs.krushmedia.com/4e4abdd5ecc661643458a730b1aa927d.gif?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redir="+url.QueryEscape(externalURL)+"%2Fsetuid%3Fbidder%3Dkrushmedia%26uid%3D%5BUID%5D")

New Adapter: jixie #1698

New Adapter: jixie #1698

Conversation

jxdeveloper1 commented Feb 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guscarreon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guscarreon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guscarreon left a comment

Choose a reason for hiding this comment

guscarreon left a comment

Choose a reason for hiding this comment

jxdeveloper1 commented Feb 24, 2021 • edited Loading

hhhjort commented Feb 24, 2021

guscarreon left a comment

Choose a reason for hiding this comment

jxdeveloper1 commented Feb 25, 2021 • edited Loading

hhhjort left a comment

Choose a reason for hiding this comment

jxdeveloper1 commented Feb 24, 2021 •

edited

Loading

jxdeveloper1 commented Feb 25, 2021 •

edited

Loading