I1503: Added dealTierSatisfied parameters in exchange.pbsOrtbBid and openrtb_ext.ExtBidPrebid and dealPriority in openrtb_ext.ExtBidPrebid #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…].bid[j].ext.prebid.dealpriority and response.seatbid[i].bid[j].ext.prebid.dealTierSatisfied respectively.
ShriprasadM
commented
Oct 29, 2020
exchange/exchange.go
Outdated
| @@ -303,6 +303,7 @@ func validateAndNormalizeDealTier(impDeal *DealTier) bool { | |||
| func updateHbPbCatDur(bid *pbsOrtbBid, dealTierInfo *DealTierInfo, bidCategory map[string]string) { | |||
| if bid.dealPriority >= dealTierInfo.MinDealTier { | |||
There was a problem hiding this comment.
Looking at function name - updateHbPbCatDur, Can we move the following condition outside of this function
if bid.dealPriority >= dealTierInfo.MinDealTier {
after the change, It will look like
if validateDealTier(impDeal[bidder]) && topBidPerBidder.dealPriority >= impDeal[bidder].MinDealTier {
topBidPerBidder.dealTierSatisfied = true
updateHbPbCatDur(topBidPerBidder, impDeal[bidder], bidCategory)
}
ShriprasadM
changed the title
ShriprasadM
changed the title
guscarreon
approved these changes
Nov 4, 2020
| @@ -1351,7 +1351,7 @@ func (m *mockExchangeVideo) HoldAuction(ctx context.Context, bidRequest *openrtb | |||
| if debugLog != nil && debugLog.Enabled { | |||
| m.cache.called = true | |||
| } | |||
| ext := []byte(`{"prebid":{"targeting":{"hb_bidder_appnexus":"appnexus","hb_pb_appnexus":"20.00","hb_pb_cat_dur_appnex":"20.00_395_30s","hb_size":"1x1", "hb_uuid_appnexus":"837ea3b7-5598-4958-8c45-8e9ef2bf7cc1"},"type":"video"},"bidder":{"appnexus":{"brand_id":1,"auction_id":7840037870526938650,"bidder_id":2,"bid_ad_type":1,"creative_info":{"video":{"duration":30,"mimes":["video\/mp4"]}}}}}`) | |||
| ext := []byte(`{"prebid":{"targeting":{"hb_bidder_appnexus":"appnexus","hb_pb_appnexus":"20.00","hb_pb_cat_dur_appnex":"20.00_395_30s","hb_size":"1x1", "hb_uuid_appnexus":"837ea3b7-5598-4958-8c45-8e9ef2bf7cc1"},"type":"video","dealpriority":0,"dealtiersatisfied":false},"bidder":{"appnexus":{"brand_id":1,"auction_id":7840037870526938650,"bidder_id":2,"bid_ad_type":1,"creative_info":{"video":{"duration":30,"mimes":["video\/mp4"]}}}}}`) | |||
There was a problem hiding this comment.
This modification is not needed because, when ommited, both missing JSON int and boolean fields default to 0 and false respectively. Anyway, not a big deal if included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added