Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TCF 1/2 Vendor List Fetcher Tests #1441

Merged
merged 5 commits into from
Sep 8, 2020
Merged

Refactor TCF 1/2 Vendor List Fetcher Tests #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2f26d9
Update Tests For vendorListURLMaker
SyntaxNode Aug 12, 2020
6139ee5
Refactor Vendor List Tests
SyntaxNode Aug 17, 2020
e63e03a
Merge branch 'master' into gvl_tests
SyntaxNode Aug 17, 2020
1fc4790
Merge branch 'master' into gvl_tests
SyntaxNode Sep 3, 2020
db417e4
Renamed Versions For Clarity
SyntaxNode Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions gdpr/gdpr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ type Permissions interface {
AMPException() bool
}

// Versions of the GDPR TCF technical specification.
const (
tCF1 uint8 = 1
tCF2 uint8 = 2
tcf1SpecVersion uint8 = 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like tcf1SpecVersion. Other possibilities are tcf1Version, tcf1Spec, tcfSpecVersion, tcfSpec1. I can't use just tcf due to package name collisions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be a good solution here unfortunately.

tcf2SpecVersion uint8 = 2
)

// NewPermissions gets an instance of the Permissions for use elsewhere in the project.
Expand All @@ -45,8 +46,8 @@ func NewPermissions(ctx context.Context, cfg config.GDPR, vendorIDs map[openrtb_
cfg: cfg,
vendorIDs: vendorIDs,
fetchVendorList: map[uint8]func(ctx context.Context, id uint16) (vendorlist.VendorList, error){
tCF1: newVendorListFetcher(ctx, cfg, client, vendorListURLMaker, tCF1),
tCF2: newVendorListFetcher(ctx, cfg, client, vendorListURLMaker, tCF2)},
tcf1SpecVersion: newVendorListFetcher(ctx, cfg, client, vendorListURLMaker, tcf1SpecVersion),
tcf2SpecVersion: newVendorListFetcher(ctx, cfg, client, vendorListURLMaker, tcf2SpecVersion)},
}
}

Expand Down
Loading