[TripleLift] - Allow usersync redirect #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-to-usersync TL-12297 - TripleLift - Add redirect to usersync
[October 2019] Pull Latest Version of prebid-server
SyntaxNode
reviewed
Oct 22, 2019
Fix Supplier ID in Test JSON
SyntaxNode
reviewed
Oct 25, 2019
adapters/triplelift/usersync_test.go
Outdated
| @@ -8,11 +8,11 @@ import ( | |||
| ) | |||
|
|
|||
| func TestTripleliftSyncer(t *testing.T) { | |||
| temp := template.Must(template.New("sync-template").Parse("//eb2.3lift.com/sync?gdpr={{.GDPR}}&cmp_cs={{.GDPRConsent}}")) | |||
| temp := template.Must(template.New("sync-template").Parse("//eb2.3lift.com/getuid?gdpr={{.GDPR}}&cmp_cs={{.GDPRConsent}}")) | |||
There was a problem hiding this comment.
Please extend this test to include verification of the redirect URL templating.
Update UsersyncTest Template
|
@SyntaxNode Updated the test |
SyntaxNode
reviewed
Oct 29, 2019
adapters/triplelift/usersync_test.go
Outdated
| @@ -8,11 +8,11 @@ import ( | |||
| ) | |||
|
|
|||
| func TestTripleliftSyncer(t *testing.T) { | |||
| temp := template.Must(template.New("sync-template").Parse("//eb2.3lift.com/sync?gdpr={{.GDPR}}&cmp_cs={{.GDPRConsent}}")) | |||
| temp := template.Must(template.New("sync-template").Parse("//eb2.3lift.com/getuid?gdpr={{.GDPR}}&cmp_cs={{.GDPRConsent}}&redir=https%3A%2F%2Feb2.3lift.com%2Fsync%3Fbidder%triplelift%26gdpr%3D{{.GDPR}}%26gdpr_consent%3D{{.GDPRConsent}}%26uid%3D%24UID")) | |||
There was a problem hiding this comment.
It looks like the redirect URL has an incomplete escape character sequence. In this test, it is:
bidder%triplelift
.. and in the config it is ...
bidder%3Dtriplelift%
There was a problem hiding this comment.
Unfilled extension should be ...%2Fsetuid%3Fbidder%3Dtriplelift%26gdpr%3D{{.GDPR}}%26gdpr_consent%3D{{.GDPRConsent}}%26uid%3D%24UID in both test and config now.
There was a problem hiding this comment.
Looks good. Thank you. I'll ask @mansinahar to provide the second approval.
Adjust inconsistency with test and sync url
SyntaxNode
approved these changes
Oct 29, 2019
mansinahar
approved these changes
Oct 29, 2019
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the concern raised in: #1038
cc: @Kevin-P-Kerr